fix: handle -- trigger terminator and -P flag in spec section header parsing#189
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes RPM spec section header parsing to correctly handle -- trigger terminator and -P priority flag in %trigger*/%filetrigger* sections, preventing mis-attribution of trigger conditions as sub-package names.
Changes:
- Treat
--as a terminator inGetPackageNameFromSectionHeader, stopping the scan so trigger conditions aren't picked up as the owning sub-package. - Skip the
-P <priority>flag (file trigger priority) as a two-token flag. - Add unit-test coverage for
%triggerin --, suffix-form,-nform,-pinteraction, and%filetriggerin -P.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/rpm/spec/spec.go | Adds -- terminator and -P flag handling to the section-header token scanner. |
| internal/rpm/spec/spec_test.go | Adds assertions covering trigger terminator, -n form, suffix form, and -P file-trigger flag. |
…parsing [GetPackageNameFromSectionHeader] did not recognize '--' as a terminator in trigger section headers. In RPM trigger syntax, '--' separates the owning sub-package from the trigger condition (e.g. '%triggerin -- devel' means the main package triggers on devel, not that the trigger belongs to subpackage devel). Also add '-P' flag handling for file trigger priority arguments. Fixes microsoft#143
trungams
force-pushed
the
tvuong/fix/trigger-separator
branch
from
d6f7e92 to
20979e8
Compare
reubeno
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetPackageNameFromSectionHeaderdid not recognize '--' as a terminator in trigger section headers. In RPM trigger syntax, '--' separates the owning sub-package from the trigger condition (e.g. '%triggerin -- devel' means the main package triggers on devel, not that the trigger belongs to subpackage devel).Also add '-P' flag handling for file trigger priority arguments.
Fixes #143