Skip to content

fix(ffmpeg): remove dependency on opus to drop it#17118

Merged
reubeno merged 1 commit into
tomls/base/mainfrom
bphilip/opus-ffmpeg-elide
May 12, 2026
Merged

fix(ffmpeg): remove dependency on opus to drop it#17118
reubeno merged 1 commit into
tomls/base/mainfrom
bphilip/opus-ffmpeg-elide

Conversation

@binujp
Copy link
Copy Markdown
Contributor

@binujp binujp commented May 11, 2026

Remove BuildRequires: pkgconfig(opus) and replace --enable-libopus
with --disable-libopus in the configure flags. ffmpeg retains its
built-in opus codec but no longer links against the external libopus
library, removing the dependency on the opus package.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com
Part of the effort to remove opus, opusfile, and mingw-opus from Azure Linux.

Copilot AI review requested due to automatic review settings May 11, 2026 05:12
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes ffmpeg’s build-time dependency on the external opus library to support dropping opus/related packages from Azure Linux, by disabling libopus integration in the ffmpeg build.

Changes:

  • Removes BuildRequires: pkgconfig(opus) from the ffmpeg spec.
  • Replaces --enable-libopus with --disable-libopus in ffmpeg’s %build configure flags.
  • Introduces an ffmpeg component definition (ffmpeg.comp.toml) with overlays and moves ffmpeg out of the inline components.toml list; updates the ffmpeg lock fingerprint accordingly.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
specs/f/ffmpeg/ffmpeg.spec Rendered spec updated to drop opus BuildRequires and disable libopus.
locks/ffmpeg.lock Updates input-fingerprint to reflect component definition changes.
base/comps/ffmpeg/ffmpeg.comp.toml New component file adding overlays to remove opus BuildRequires and flip the configure flag.
base/comps/components.toml Removes inline [components.ffmpeg] entry now that ffmpeg has a dedicated .comp.toml.

@@ -0,0 +1,16 @@
[components.ffmpeg]

# AZL does not ship opus — remove the opus codec from ffmpeg.
Comment on lines +15 to +16
regex = '--enable-libopus \\'
replacement = '--disable-libopus \'
@binujp binujp force-pushed the bphilip/opus-ffmpeg-elide branch from ebb5eec to 88890e6 Compare May 11, 2026 15:02
Remove BuildRequires: pkgconfig(opus) and replace --enable-libopus
with --disable-libopus in the configure flags. ffmpeg retains its
built-in opus codec but no longer links against the external libopus
library, removing the dependency on the opus package.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@binujp binujp force-pushed the bphilip/opus-ffmpeg-elide branch from 88890e6 to 1bcc35b Compare May 11, 2026 15:25
@reubeno reubeno merged commit 1773f93 into tomls/base/main May 12, 2026
10 checks passed
@reubeno reubeno deleted the bphilip/opus-ffmpeg-elide branch May 12, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants