fix(ffmpeg): remove dependency on opus to drop it#17118
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes ffmpeg’s build-time dependency on the external opus library to support dropping opus/related packages from Azure Linux, by disabling libopus integration in the ffmpeg build.
Changes:
- Removes
BuildRequires: pkgconfig(opus)from the ffmpeg spec. - Replaces
--enable-libopuswith--disable-libopusin ffmpeg’s%buildconfigure flags. - Introduces an ffmpeg component definition (
ffmpeg.comp.toml) with overlays and moves ffmpeg out of the inlinecomponents.tomllist; updates the ffmpeg lock fingerprint accordingly.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| specs/f/ffmpeg/ffmpeg.spec | Rendered spec updated to drop opus BuildRequires and disable libopus. |
| locks/ffmpeg.lock | Updates input-fingerprint to reflect component definition changes. |
| base/comps/ffmpeg/ffmpeg.comp.toml | New component file adding overlays to remove opus BuildRequires and flip the configure flag. |
| base/comps/components.toml | Removes inline [components.ffmpeg] entry now that ffmpeg has a dedicated .comp.toml. |
| @@ -0,0 +1,16 @@ | |||
| [components.ffmpeg] | |||
|
|
|||
| # AZL does not ship opus — remove the opus codec from ffmpeg. | |||
Comment on lines
+15
to
+16
| regex = '--enable-libopus \\' | ||
| replacement = '--disable-libopus \' |
ebb5eec to
88890e6
Compare
Remove BuildRequires: pkgconfig(opus) and replace --enable-libopus with --disable-libopus in the configure flags. ffmpeg retains its built-in opus codec but no longer links against the external libopus library, removing the dependency on the opus package. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
88890e6 to
1bcc35b
Compare
reubeno
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove BuildRequires: pkgconfig(opus) and replace --enable-libopus
with --disable-libopus in the configure flags. ffmpeg retains its
built-in opus codec but no longer links against the external libopus
library, removing the dependency on the opus package.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com
Part of the effort to remove
opus,opusfile, andmingw-opusfrom Azure Linux.