fix(freerdp): remove dependency on opus to drop it#17119
Merged
Conversation
binujp
requested review from
christopherco,
ddstreetmicrosoft and
reubeno
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the freerdp component to remove its dependency on opus by dropping the pkgconfig(opus) build requirement and disabling Opus support in the CMake configuration, aligning with the broader effort to remove opus/opusfile/mingw-opus from Azure Linux.
Changes:
- Removed
BuildRequires: pkgconfig(opus)from the renderedfreerdp.spec. - Switched the build configuration from
-DWITH_OPUS=ONto-DWITH_OPUS=OFF. - Added a dedicated
freerdp.comp.tomlwith overlays and removed the inlinefreerdpentry frombase/comps/components.toml.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
specs/f/freerdp/freerdp.spec |
Rendered spec updated to drop Opus BuildRequires and disable Opus via CMake flag. |
locks/freerdp.lock |
Updated input fingerprint to reflect the component definition changes. |
base/comps/freerdp/freerdp.comp.toml |
New component overlay file implementing the Opus removal/disablement. |
base/comps/components.toml |
Removed inline freerdp component entry now that it has a dedicated .comp.toml. |
Comment on lines
+11
to
+15
| [[components.freerdp.overlays]] | ||
| description = "Disable opus audio codec in FreeRDP (-DWITH_OPUS=OFF)" | ||
| type = "spec-search-replace" | ||
| section = "%build" | ||
| regex = '-DWITH_OPUS=ON \\' |
binujp
force-pushed
the
bphilip/opus-freerdp-elide
branch
from
7dd1670 to
d45c225
Compare
Remove BuildRequires: pkgconfig(opus) and set -DWITH_OPUS=OFF in cmake flags. FreeRDP no longer requires the opus package. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
binujp
force-pushed
the
bphilip/opus-freerdp-elide
branch
from
d45c225 to
74f95e6
Compare
reubeno
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove BuildRequires: pkgconfig(opus) and set -DWITH_OPUS=OFF in
cmake flags. FreeRDP no longer requires the opus package.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com
Part of the effort to remove
opus,opusfile, andmingw-opusfrom Azure Linux.