fix(gstreamer1-plugins-base): remove dependency on opus to drop it#17121
Open
binujp wants to merge 1 commit into
Open
fix(gstreamer1-plugins-base): remove dependency on opus to drop it#17121binujp wants to merge 1 commit into
binujp wants to merge 1 commit into
Conversation
binujp
requested review from
christopherco,
ddstreetmicrosoft and
reubeno
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the gstreamer1-plugins-base component to remove its build-time and runtime packaging dependency on opus, aligning with the effort to drop opus (and related packages) from Azure Linux.
Changes:
- Drops
opus-develfromBuildRequiresand disables the opus meson option (-D opus=disabled) during%build. - Removes the
libgstopus.soplugin from the packaged%fileslist. - Introduces a dedicated component definition with overlays and updates the component lock fingerprint accordingly.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| specs/g/gstreamer1-plugins-base/gstreamer1-plugins-base.spec | Rendered spec reflects removal of opus-devel, adds -D opus=disabled, and stops packaging libgstopus.so. |
| locks/gstreamer1-plugins-base.lock | Updates input fingerprint to match the component definition changes. |
| base/comps/gstreamer1-plugins-base/gstreamer1-plugins-base.comp.toml | Adds overlays to remove the BR, inject the meson flag, and remove the opus plugin from %files. |
| base/comps/components.toml | Removes the inline component entry now that a dedicated .comp.toml defines the component. |
reubeno
reviewed
May 11, 2026
| section = "%build" | ||
| regex = '-D tremor=disabled' | ||
| replacement = """-D opus=disabled \\ | ||
| -D tremor=disabled""" |
Member
There was a problem hiding this comment.
Avoid referencing an unrelated option?
Collaborator
There was a problem hiding this comment.
Consider using %meson \ as your anchor point
Remove opus-devel BuildRequires, add -Dopus=disabled meson flag, and remove libgstopus.so from %files. This is to allow removal of the opus package from AZL. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
binujp
force-pushed
the
bphilip/opus-gstreamer1-plugins-base-elide
branch
from
cb4d114 to
abcfddd
Compare
christopherco
requested changes
May 12, 2026
| section = "%build" | ||
| regex = '-D tremor=disabled' | ||
| replacement = """-D opus=disabled \\ | ||
| -D tremor=disabled""" |
Collaborator
There was a problem hiding this comment.
Consider using %meson \ as your anchor point
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove opus-devel BuildRequires, add -Dopus=disabled meson flag, and
remove libgstopus.so from %files. This is to allow removal of the opus package from AZL.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com
Part of the effort to remove
opus,opusfile, andmingw-opusfrom Azure Linux.