Skip to content

fix(gstreamer1-plugins-bad-free): remove dependency on opus to drop it#17122

Merged
reubeno merged 1 commit into
tomls/base/mainfrom
bphilip/opus-gstreamer1-plugins-bad-free-elide
May 12, 2026
Merged

fix(gstreamer1-plugins-bad-free): remove dependency on opus to drop it#17122
reubeno merged 1 commit into
tomls/base/mainfrom
bphilip/opus-gstreamer1-plugins-bad-free-elide

Conversation

@binujp
Copy link
Copy Markdown
Contributor

@binujp binujp commented May 11, 2026

Remove pkgconfig(opus) BuildRequires, add -Dopus=disabled meson flag,
and remove libgstopusparse.so from %files. This is to allow removal of the opus package from AZL.

Co-authored-by: Copilot [email protected]
Part of the effort to remove opus, opusfile, and mingw-opus from Azure Linux.

@binujp binujp requested a review from ddstreetmicrosoft as a code owner May 11, 2026 05:13
Copilot AI review requested due to automatic review settings May 11, 2026 05:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Azure Linux packaging for gstreamer1-plugins-bad-free to remove the build/runtime closure on opus, enabling opus (and related packages) to be dropped from the distro.

Changes:

  • Removed pkgconfig(opus) from BuildRequires.
  • Disabled Opus support in the Meson build configuration and removed the Opus parse plugin from %files.
  • Introduced a dedicated component definition (.comp.toml) and updated the lock fingerprint accordingly.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
specs/g/gstreamer1-plugins-bad-free/gstreamer1-plugins-bad-free.spec Rendered spec updates: drop opus BR, disable opus in Meson flags, remove opus plugin from %files.
locks/gstreamer1-plugins-bad-free.lock Updates the component input fingerprint to reflect the config changes.
base/comps/gstreamer1-plugins-bad-free/gstreamer1-plugins-bad-free.comp.toml New component overlays implementing the opus removal/disablement.
base/comps/components.toml Removes the inline component entry now that a dedicated .comp.toml exists.

Comment thread base/comps/gstreamer1-plugins-bad-free/gstreamer1-plugins-bad-free.comp.toml Outdated
Comment thread base/comps/gstreamer1-plugins-bad-free/gstreamer1-plugins-bad-free.comp.toml Outdated
@binujp binujp force-pushed the bphilip/opus-gstreamer1-plugins-bad-free-elide branch from 56bb4c1 to 996a3af Compare May 11, 2026 15:03
Copy link
Copy Markdown
Collaborator

@christopherco christopherco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix anchor point for regex

@binujp binujp force-pushed the bphilip/opus-gstreamer1-plugins-bad-free-elide branch from 996a3af to a34a6ab Compare May 12, 2026 18:01
Remove pkgconfig(opus) BuildRequires, add -Dopus=disabled meson flag,
and remove libgstopusparse.so from %files. This is to allow removal of the opus package from AZL.

Co-authored-by: Copilot <[email protected]>
@binujp binujp force-pushed the bphilip/opus-gstreamer1-plugins-bad-free-elide branch from a34a6ab to 3d46910 Compare May 12, 2026 20:28
@binujp binujp dismissed christopherco’s stale review May 12, 2026 20:58

Fixed in the latest iteration

@reubeno reubeno merged commit 52969ac into tomls/base/main May 12, 2026
10 checks passed
@reubeno reubeno deleted the bphilip/opus-gstreamer1-plugins-bad-free-elide branch May 12, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants