fix(jack-audio-connection-kit): remove dependency on opus to drop it#17123
Merged
reubeno merged 1 commit intoMay 12, 2026
Merged
Conversation
binujp
requested review from
christopherco,
ddstreetmicrosoft and
reubeno
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the jack-audio-connection-kit component to avoid linking/building against opus, enabling the broader effort to remove opus from Azure Linux while keeping JACK buildable.
Changes:
- Removed
opus-develfromBuildRequiresforjack-audio-connection-kit. - Added
--no-opusto the%buildwaf configureinvocation to prevent auto-detection. - Introduced a dedicated component definition (
.comp.toml) with overlays, and removed the now-nontrivial inline component entry fromcomponents.toml.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| specs/j/jack-audio-connection-kit/jack-audio-connection-kit.spec | Rendered spec updates: drops opus-devel BR and disables opus via --no-opus. |
| locks/jack-audio-connection-kit.lock | Updates component input fingerprint after config/spec overlay changes. |
| base/comps/jack-audio-connection-kit/jack-audio-connection-kit.comp.toml | New component overlays to remove the opus BR and inject --no-opus during %build. |
| base/comps/components.toml | Removes inline jack-audio-connection-kit entry since it now has a dedicated .comp.toml. |
reubeno
reviewed
May 11, 2026
binujp
force-pushed
the
bphilip/opus-jack-audio-connection-kit-elide
branch
from
e2763a4 to
9278252
Compare
christopherco
previously requested changes
May 12, 2026
Collaborator
christopherco
left a comment
christopherco
left a comment
There was a problem hiding this comment.
Please fix the regex anchor
Remove opus-devel BuildRequires and add --no-opus to waf configure to prevent auto-detection. This is to allow removal of the opus package from AZL. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
binujp
force-pushed
the
bphilip/opus-jack-audio-connection-kit-elide
branch
from
9278252 to
be84286
Compare
reubeno
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove opus-devel BuildRequires and add --no-opus to waf configure
to prevent auto-detection. This is to allow removal of the opus package from AZL.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com
Part of the effort to remove
opus,opusfile, andmingw-opusfrom Azure Linux.