fix(spice): remove dependency on opus to drop it#17126
Merged
Merged
Conversation
binujp
requested review from
christopherco,
ddstreetmicrosoft and
reubeno
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the opus build dependency from the spice component and disables opus support in the Meson build configuration, supporting the broader effort to drop opus (and related packages) from Azure Linux.
Changes:
- Added a dedicated
spice.comp.tomlwith overlays to removeopus-develBuildRequiresand flip Meson from-Dopus=enabledto-Dopus=disabled. - Updated the rendered
specs/s/spice/spice.specto reflect the overlayed build configuration. - Updated
locks/spice.lockinput fingerprint and removed the inlinespiceentry frombase/comps/components.toml(since it’s now customized via a dedicated comp file).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| specs/s/spice/spice.spec | Rendered spec updated: drops opus-devel and disables opus in %meson args. |
| locks/spice.lock | Updates input fingerprint to reflect component definition changes. |
| base/comps/spice/spice.comp.toml | Introduces overlays to remove opus-devel and disable opus in the Meson build. |
| base/comps/components.toml | Removes inline [components.spice] entry now that spice is customized via a dedicated comp file. |
Remove opus-devel BuildRequires and change -Dopus=enabled to -Dopus=disabled in meson build. This is to allow removal of the opus package from AZL. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
binujp
force-pushed
the
bphilip/opus-spice-elide
branch
from
a64db60 to
512e71a
Compare
christopherco
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove opus-devel BuildRequires and change -Dopus=enabled to
-Dopus=disabled in meson build. This is to allow removal of the opus package from AZL.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com
Part of the effort to remove
opus,opusfile, andmingw-opusfrom Azure Linux.