fix(spice-gtk): remove dependency on opus to drop it#17127
Open
binujp wants to merge 1 commit into
Open
Conversation
binujp
requested review from
christopherco,
ddstreetmicrosoft and
reubeno
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the spice-gtk component configuration to remove the build-time dependency on opus (which Azure Linux intends to drop) by removing opus-devel from BuildRequires and explicitly disabling opus support in the Meson build.
Changes:
- Added a dedicated
spice-gtk.comp.tomlwith overlays to removeopus-develand inject-Dopus=disabledinto the%buildMeson invocation. - Updated the rendered
spice-gtk.specto reflect the removed BuildRequires and new Meson option. - Refreshed the
spice-gtklock fingerprint and moved the component entry out of the inlinecomponents.tomllist.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
specs/s/spice-gtk/spice-gtk.spec |
Drops BuildRequires: opus-devel and adds -Dopus=disabled to the Meson configure flags in %build. |
locks/spice-gtk.lock |
Updates the component input fingerprint to match the new component definition/overlays. |
base/comps/spice-gtk/spice-gtk.comp.toml |
Introduces overlays to remove the opus BuildRequires and disable opus via Meson. |
base/comps/components.toml |
Removes the inline [components.spice-gtk] entry now that the component is defined in a dedicated .comp.toml. |
Comment on lines
+15
to
+17
| regex = '-Dbuiltin-mjpeg=false' | ||
| replacement = """-Dopus=disabled \\ | ||
| -Dbuiltin-mjpeg=false""" |
reubeno
reviewed
May 11, 2026
| description = "Disable opus audio codec in meson build" | ||
| type = "spec-search-replace" | ||
| section = "%build" | ||
| regex = '-Dbuiltin-mjpeg=false' |
Member
There was a problem hiding this comment.
Would it be cleaner to search for %meson \ or similar? That's a bit less specific.
Remove opus-devel BuildRequires and add -Dopus=disabled to meson build. This is to allow removal of the opus package from AZL. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
binujp
force-pushed
the
bphilip/opus-spice-gtk-elide
branch
from
89112b8 to
dc6c180
Compare
christopherco
requested changes
May 12, 2026
Collaborator
christopherco
left a comment
christopherco
left a comment
There was a problem hiding this comment.
Fix regex anchor and merge conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove opus-devel BuildRequires and add -Dopus=disabled to meson
build. This is to allow removal of the opus package from AZL.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com
Part of the effort to remove
opus,opusfile, andmingw-opusfrom Azure Linux.