fix(wireshark): remove dependency on opus to drop it#17128
Merged
Conversation
binujp
requested review from
christopherco,
ddstreetmicrosoft and
reubeno
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the opus-devel build dependency from the wireshark component so Wireshark builds without Opus RTP audio playback support, enabling the opus package to be removed from Azure Linux while keeping Wireshark buildable.
Changes:
- Added a
wiresharkcomponent overlay to remove theBuildRequires: opus-develtag during rendering. - Updated the rendered Wireshark spec to reflect the removed build requirement.
- Updated the
wiresharklock fingerprint and movedwiresharkout of the “unmodified Fedora imports” inline component list.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| specs/w/wireshark/wireshark.spec | Rendered spec no longer includes BuildRequires: opus-devel. |
| locks/wireshark.lock | Updates input fingerprint to match the component config change. |
| base/comps/wireshark/wireshark.comp.toml | New component overlay removing opus-devel BuildRequires with spec-remove-tag. |
| base/comps/components.toml | Removes inline [components.wireshark] entry since the component now has per-component customization. |
Remove opus-devel BR. Wireshark auto-detects opus and builds without Opus RTP audio playback when it is absent. This is to allow removal of the opus package from AZL. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
binujp
force-pushed
the
bphilip/opus-wireshark-elide
branch
from
5878bb5 to
da11c47
Compare
christopherco
approved these changes
May 12, 2026
Collaborator
christopherco
left a comment
christopherco
left a comment
There was a problem hiding this comment.
LGTM. Added a non-blocking suggestion to upstream a toggle to Fedora
| @@ -0,0 +1,10 @@ | |||
| [components.wireshark] | |||
Collaborator
There was a problem hiding this comment.
suggestion (non-blocking): Consider upstreaming a change to Fedora to allow toggling -DENABLE_OPUS=ON/OFF in cmake invocation. Then we can use that in the future to ensure opus isn't built.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove opus-devel BR. Wireshark auto-detects opus and builds without
Opus RTP audio playback when it is absent. This is to allow removal of the opus package from AZL.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com
Part of the effort to remove
opus,opusfile, andmingw-opusfrom Azure Linux.