chore: remove rust-dolby_vision#17130
Merged
Merged
Conversation
Patch libplacebo to build with -Dlibdovi=disabled and drop the libdovi-devel BuildRequires. libdovi (from the rust-dolby_vision SRPM) is the only external consumer keeping rust-dolby_vision in Azure Linux 4.0; disabling it here unblocks removal of the SRPM in a follow-up commit. The -Dlibdovi=disabled Meson option is upstream-supported and only controls parsing of Dolby Vision RPU metadata at runtime. Standard HDR10 / HDR10+ paths in libplacebo and its consumers (ffmpeg, mpv, plasma-*, weston, etc.) are unaffected. Move the component to a dedicated comp.toml so the overlays have a home; the inline entry in components.toml is dropped accordingly.
Remove the rust-dolby_vision SRPM and all 9 of its binary subpackages (libdovi, libdovi-devel, rust-dolby_vision-devel, and 6 feature shims) from Azure Linux 4.0. Reverse-dep analysis identified libplacebo as the only external consumer (build-time, via pkgconfig(dovi)). The previous commit disables libdovi support in libplacebo, leaving rust-dolby_vision with zero consumers in the distro. Cascade verification on both x86_64 and aarch64 shows no remaining references after the libplacebo rebuild. Removes the inline component entry, the SDK package list entries for all binary subpackages, the lock file, and the rendered spec directory.
christopherco
force-pushed
the
chrco/remove-rust-dolby-vision
branch
from
68652a6 to
908c9bf
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the rust-dolby_vision SRPM (and its binary subpackages) from Azure Linux by first disabling libplacebo’s optional libdovi integration, then deleting the component artifacts and SDK package list entries.
Changes:
- Disable Dolby Vision (
libdovi) support inlibplaceboby droppingBuildRequires: libdovi-develand forcing-Dlibdovi=disabledin the Meson configuration. - Remove
rust-dolby_visionfrom the distro by deleting its lock + rendered spec artifacts and removing its SDK package list entries. - Move
libplacebofrom an inline components entry to a dedicated*.comp.tomlwith overlays.
Reviewed changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| base/comps/libplacebo/libplacebo.comp.toml | New component definition with overlays to remove libdovi BuildRequires and inject -Dlibdovi=disabled. |
| specs/l/libplacebo/libplacebo.spec | Rendered spec updated accordingly (drops BR, adds Meson option, bumps autorelease/changelog). |
| locks/libplacebo.lock | Lock fingerprint updated to reflect the component config change. |
| base/comps/components.toml | Removes inline entries for libplacebo (now dedicated file) and rust-dolby_vision (removed). |
| base/packages/sdk.packages.toml | Removes libdovi* and rust-dolby_vision* binary package entries from the SDK package list. |
| locks/rust-dolby_vision.lock | Deleted lock for the removed component. |
| specs/r/rust-dolby_vision/rust-dolby_vision.spec | Deleted rendered spec for the removed component. |
| specs/r/rust-dolby_vision/sources | Deleted sources metadata for the removed component. |
| specs/r/rust-dolby_vision/dolby_vision-fix-metadata.diff | Deleted rendered patch artifact associated with the removed component. |
| specs/r/rust-dolby_vision/dolby_vision-a8e639d.patch | Deleted rendered patch artifact associated with the removed component. |
reubeno
approved these changes
May 12, 2026
| type = "spec-search-replace" | ||
| section = "%build" | ||
| regex = '^%meson \\$' | ||
| replacement = '''%meson \ |
Member
There was a problem hiding this comment.
(Observation) Sounds like this really wants a spec-insert-line-after?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
rust-dolby_visionSRPM and all 9 of its binary subpackages (libdovi,libdovi-devel,rust-dolby_vision-devel, and 6 feature shims) from Azure Linux.libplacebois the only external consumer oflibdoviin the distro (build-time, viapkgconfig(dovi)). The first commit patcheslibplaceboto build with-Dlibdovi=disabledand drops theBuildRequires, leavingrust-dolby_visionwith zero consumers. The second commit removes the SRPM.Commits
fix(libplacebo): disable Dolby Vision support— moveslibplaceboto a dedicatedcomp.toml, adds two overlays (dropBuildRequires: libdovi-devel, inject-Dlibdovi=disabledinto%meson), refreshes lock and rendered spec.chore(rust-dolby_vision): remove from distro— drops the inline component entry, the SDK package list entries for all 9 subpackages, the lock file, and the rendered spec directory.Functional impact
libplacebo(and downstream consumers — ffmpeg, mpv, plasma-*, weston, etc.) will no longer parse Dolby Vision RPU metadata. Standard HDR10 / HDR10+ paths are unaffected. The-Dlibdovi=disabledMeson option is upstream-supported.Fixes: AB#19712