fix(firefox): repack source tarball without obfuscated ff-inst.exe#17133
Draft
anphel31 wants to merge 5 commits into
Draft
fix(firefox): repack source tarball without obfuscated ff-inst.exe#17133anphel31 wants to merge 5 commits into
anphel31 wants to merge 5 commits into
Conversation
6a87246 to
3261e50
Compare
PawelWMS
reviewed
May 11, 2026
| # 1. Update --version in modify_source.sh (and UPSTREAM_SHA512). | ||
| # 2. Re-run the script and copy the new SHA-256 into the source-files entry. | ||
| # 3. Upload the new tarball to the modified-source lookaside (see script output). | ||
| [[components.firefox.overlays]] |
Contributor
There was a problem hiding this comment.
Let's wait for this azldev update to go in, so you can replace the original upstream source and make this TOML config simpler.
PawelWMS
reviewed
May 11, 2026
| az storage blob upload \\ | ||
| --account-name azltempstaginglookaside \\ | ||
| --container-name repo \\ | ||
| --name "pkgs_modified/firefox/${OUTPUT_NAME}/sha256/\$(awk '{print \$1}' ${OUTPUT_NAME}.sha256)/${OUTPUT_NAME}" \\ |
Contributor
There was a problem hiding this comment.
This looks wrong. The sources file uses SHA-512 and here we're using SHA-256. In general, I don't think we need any SHA-256 in this script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The upstream Mozilla Firefox source tarball ships an obfuscated Windows
executable test fixture at
firefox-148.0/toolkit/components/mediasniffer/test/unit/data/ff-inst.exe.Obfuscated binaries inside our source RPMs trip the distro's RPM signing
pipeline, which blocks the SRPM from being published.
This PR replaces
Source0with a deterministically-repacked tarball that isbyte-identical to upstream except that
ff-inst.exehas been removed.ff-inst.exeis only used by Firefox's unit tests, which are not run in ourbuild (
run_firefox_tests = 0), so removing it has no effect on the shippedpackage.
Changes
base/comps/firefox/repack-source-tarball.sh— New helper script that:firefox-148.0.source.tar.xzfromarchive.mozilla.org.specs/f/firefox/sources.ff-inst.exe.firefox-148.0.azl.source.tar.xz:tar --sort=name --owner=0 --group=0 --numeric-owner --mtime=@1577836800 --format=gnu— stable file order, fixedownership and mtime, no PAX extended headers.
xz -T 4 -9 --block-size=256MiB— fixed thread count and block sizeso the SHA-256 is identical across re-runs and machines.
az storage blob uploadcommand for the AZL lookaside cache.base/comps/firefox/firefox.comp.toml— Adds:spec-update-tagoverlay rewritingSource0tofirefox-%{version}%{?pre_version}.azl.source.tar.xz(top-leveldirectory inside the tarball is unchanged, so
%setup -n firefox-...keeps working).
[[components.firefox.source-files]]entry pinning the new filename,its SHA-256, and an
originURL pointing at the AZL lookaside cache.Reproduction
Anyone can regenerate the modified tarball: