fix(sos): add all missing cloud-init systemd service units#17144
Open
jonathanbrenes wants to merge 1 commit into
Open
fix(sos): add all missing cloud-init systemd service units#17144jonathanbrenes wants to merge 1 commit into
jonathanbrenes wants to merge 1 commit into
Conversation
jonathanbrenes
requested review from
christopherco,
ddstreetmicrosoft and
reubeno
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Azure Linux sos component overlay patch for the cloud_init plugin so sos report captures systemd status for all cloud-init service units used with cloud-init 24.3+ (single-process optimization).
Changes:
- Extend the
cloud_initpluginservicestuple to includecloud-init-local,cloud-config, andcloud-final(in addition to the previously addedcloud-init-mainandcloud-init-network). - Update the
soscomponent overlay description and refresh rendered spec output (rpmautospec release/changelog). - Refresh the
soslock input fingerprint.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| specs/s/sos/sos.spec | Rendered spec release/changelog update reflecting the component change. |
| specs/s/sos/cloud_init-add-cloud-init-main-and-network-services.patch | Updated rendered patch to include additional cloud-init systemd units in the plugin. |
| locks/sos.lock | Updated input-fingerprint after component input changes. |
| base/comps/sos/sos.comp.toml | Updated overlay description referencing the newer upstream PR. |
| base/comps/sos/cloud_init-add-cloud-init-main-and-network-services.patch | Source patch updated to include cloud-init-local, cloud-config, and cloud-final. |
Update the cloud_init plugin patch to add cloud-init-local, cloud-config, and cloud-final to the services tuple, matching upstream sosreport/sos#4318 (now merged). Previously only cloud-init, cloud-init-main, and cloud-init-network were listed.
jonathanbrenes
force-pushed
the
fix/sos-cloud-init-services
branch
from
256f747 to
cc3c5cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the sos
cloud_initplugin patch to add all missing systemd service unitsintroduced by cloud-init 24.3's single-process optimization.
Services added
cloud-init-local— Local stagecloud-config— Config stagecloud-final— Final stageThese join the existing
cloud-init,cloud-init-main, andcloud-init-networkentries, so
sos reportnow captures status for all six cloud-init service units.Related
Testing
azldev comp build -p sos— succeeded, producedsos-4.11.0-4.azl4.noarch.rpmrpm -q sos→sos-4.11.0-4.azl4.noarch('cloud-init', 'cloud-init-local', 'cloud-init-network', 'cloud-init-main', 'cloud-config', 'cloud-final')