feat: support Python 3.14 by removing upper bound on requires-python#238
Open
algojogacor wants to merge 1 commit into
Open
feat: support Python 3.14 by removing upper bound on requires-python#238algojogacor wants to merge 1 commit into
algojogacor wants to merge 1 commit into
Conversation
Remove the <3.14 upper bound from requires-python in pyproject.toml and add Python 3.14 to the classifiers list. The msal dependency (which was the original blocker — see microsoft#89) has supported Python 3.14 since v1.35.0 (~3 months ago). Changes: - requires-python: ">=3.10,<3.14" → ">=3.10" - Add "Programming Language :: Python :: 3.14" classifier This follows PEP 440 best practices — upper bounds on python_requires are discouraged without a known incompatibility, which no longer applies. Resolves: microsoft#236
Contributor
There was a problem hiding this comment.
Pull request overview
Updates package metadata to declare support for Python 3.14 by removing the requires-python upper bound and adding the corresponding Trove classifier, aligning with the goal of allowing installs on newer Python versions.
Changes:
- Removed the
<3.14upper bound fromrequires-python(now>=3.10). - Added the
Programming Language :: Python :: 3.14classifier.
Comment on lines
+8
to
+15
| requires-python = ">=3.10" | ||
| classifiers = [ | ||
| "Programming Language :: Python :: 3", | ||
| "Programming Language :: Python :: 3.10", | ||
| "Programming Language :: Python :: 3.11", | ||
| "Programming Language :: Python :: 3.12", | ||
| "Programming Language :: Python :: 3.13", | ||
| "Programming Language :: Python :: 3.14", |
Comment on lines
+8
to
+15
| requires-python = ">=3.10" | ||
| classifiers = [ | ||
| "Programming Language :: Python :: 3", | ||
| "Programming Language :: Python :: 3.10", | ||
| "Programming Language :: Python :: 3.11", | ||
| "Programming Language :: Python :: 3.12", | ||
| "Programming Language :: Python :: 3.13", | ||
| "Programming Language :: Python :: 3.14", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the
<3.14upper bound fromrequires-pythoninpyproject.tomland add Python 3.14 to the classifiers list. Themsaldependency — which was the original blocker for Python 3.14 support — has been compatible since v1.35.0 (~3 months ago). There is no longer any known incompatibility that justifies the upper bound.Changes
requires-python: Changed from">=3.10,<3.14"to">=3.10"— removes the artificial upper bound"Programming Language :: Python :: 3.14"to the classifiers listRationale
msalnot supporting Python 3.14 (referenced in [FEATURE] Update CLI to support more modern python versions #89).msaladded Python 3.14 support in v1.35.0, released ~3 months agopython_requiresare discouraged by PEP 440 best practices unless there is a known incompatibilityTesting
Resolves: #236