fix: create plugin to export .js file references instead of .ts files in CEM#36104
Open
chrisdholt wants to merge 3 commits into
Open
Conversation
📊 Bundle size report✅ No changes found |
eljefe223
approved these changes
May 5, 2026
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-web-components/Badge 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/Badge. - Dark Mode.normal.chromium.png | 443 | Changed |
vr-tests-web-components/RadioGroup 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/RadioGroup. - Dark Mode.normal.chromium_1.png | 89 | Changed |
vr-tests-web-components/TextInput 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/TextInput. - Dark Mode.normal.chromium_1.png | 288 | Changed |
There were 1 duplicate changes discarded. Check the build logs for more information.
davatron5000
approved these changes
May 5, 2026
Comment on lines
+19
to
+21
| function toDistPath(sourcePath) { | ||
| return './' + sourcePath.replace(/^src\//, 'dist/esm/').replace(/\.ts$/, '.js'); | ||
| } |
Contributor
There was a problem hiding this comment.
Doesn't need to block, but do we need some validation that all modules in the CEM actually exist in the dist/esm?
Member
Author
There was a problem hiding this comment.
Good callout and we should block - there's definitely a bug in this.
Member
Author
There was a problem hiding this comment.
@davatron5000 I created a test to run (like confirming packaging) which runs after analyze-cem...take a look and let me know if you have thoughts. The previous implementation broke names in the process of conversion.
|
Pull request demo site: URL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The CEM output points to
.tsfiles.New Behavior
the CEM output uses a plugin to map
.tsoutput to.jsoutput.Related Issue(s)