fix: simplify mergeStyles argument type#36215
Open
15MariamS wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
mergeStylesdefined its public style argument type as a union ofIStyle,IStyleBaseArray, and falsey values.IStylealready includes those same falsey values and recursively includesIStyleBaseArray, so TypeScript had duplicate recursive paths to expand.New Behavior
mergeStylesnow aliases its style argument type directly toIStyle, preserving the same accepted inputs while reducing unnecessary recursive type expansion. This helps avoid excessive type instantiation errors from the public overloads.Validation
PATH=/opt/homebrew/Cellar/node@22/22.22.0/bin:$PATH node node_modules/typescript/bin/tsc -p packages/merge-styles/tsconfig.json --noEmit --skipLibCheckgit diff --checkNote:
beachball checkand the Jest command could not run in this local checkout because the dependency install left missing files insidenode_modules.Related Issue(s)