fix chart axis label prop spellings#36216
Open
15MariamS wants to merge 2 commits into
Open
Conversation
microsoft-github-policy-service
Bot
added
Needs: Author Feedback
Needs: Attention
and removed
Needs: Author Feedback
labels
Contributor
Author
This fixes #34872. These are public API props and a few of them have |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #34872.
Adds correctly spelled axis label prop aliases for chart components while keeping the existing misspelled prop names as deprecated compatibility aliases:
showXAxisLabelsTooltipwrapXAxisLabelsrotateXAxisLabelsshowYAxisLabelsshowYAxisLabelsTooltipThis covers both
@fluentui/react-chartingand@fluentui/react-charts, updates the shared chart logic to normalize the new and legacy names once, updates API baselines, and adds targeted render coverage for the new prop names.Validation
git diff --checkI was not able to run package tests locally because the dependency install did not complete in this checkout.