feat(react-compiler): enable react-compiler-analyzer lint on PR runs and apply --fix#36224
Open
Hotell wants to merge 7 commits into
Open
feat(react-compiler): enable react-compiler-analyzer lint on PR runs and apply --fix#36224Hotell wants to merge 7 commits into
Hotell wants to merge 7 commits into
Conversation
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
dmytrokirpa
approved these changes
May 20, 2026
CampbellOwen
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enable the
react-compiler-analyzer--linttarget in the PR CI pipeline as a dedicated parallel job and fix'use no memo'directives across all v9 packages, and clean up a deprecated ESLint rule.Motivation
mainjob lean while still catching React Compiler compatibility regressions before merge.--fixacross allreact-components/**ensures up to date baseline — no false positivesuse no memodirectives. TLDR, if compiler bails out, theuse no memois redundant and ourlintcommand flags itlines-around-directiverule has been deprecated since 2017 and causes unnecessary lint errors on directives like'use no memo'.Follow up
it seems we use
use no memodirective on purpose in some style hooks, compiler is able compile those as they don't modify the references rather re-set thestate. We will check the actual need of the no memo as a follow up.Modules to check:
Changes
.github/workflows/pr.ymlreact-compiler-analyzer--lintfrom themainjob'snx affectedtask list.react-compiler-analyzerjob that runs in parallel with the existing jobs (main,e2e,react-major-versions-integration). It checks out the repo, derives affected SHAs, and runsyarn nx affected -t react-compiler-analyzer--lint --nxBail.package.json— Bump@fluentui/react-compiler-analyzerfrom0.0.0-experimental.rc-analyzer.20260505-0d531266b1.0to0.0.0-experimental.rc-analyzer.20260514-5d0a891a8f.0.react-components/**— Runreact-compiler-analyzer --fixacross all v9 packages: removed redundant'use no memo'directives and added justification comments to valid ones (~380 files changed).packages/eslint-plugin/src/configs/core.js— Disable the deprecatedlines-around-directiveESLint rule (deprecated since ESLint v4, inherited from airbnb config).yarn.lock— Updated lockfile reflecting the version bump.