Skip to content

feat(proxy): support socks5 proxy authentication#40845

Open
pavelfeldman wants to merge 1 commit into
microsoft:mainfrom
pavelfeldman:fix-10567
Open

feat(proxy): support socks5 proxy authentication#40845
pavelfeldman wants to merge 1 commit into
microsoft:mainfrom
pavelfeldman:fix-10567

Conversation

@pavelfeldman
Copy link
Copy Markdown
Member

@pavelfeldman pavelfeldman commented May 14, 2026

Summary

  • Front user-provided SOCKS5 upstream with a local unauthenticated SOCKS5 server that forwards each connection through with RFC 1929 credentials, mirroring the ClientCertificatesProxy pattern.
  • Works uniformly across Chromium, Firefox, and WebKit; no per-browser changes.
  • Removes the long-standing Browser does not support socks5 proxy authentication rejection.

Fixes #10567

@pavelfeldman
feat(proxy): support socks5 proxy authentication
3f52a95 
Browsers do not natively implement RFC 1929 SOCKS5 username/password
authentication. Front the user-provided upstream with a local
unauthenticated SOCKS5 server that forwards each connection through to
the upstream with credentials. Works uniformly across Chromium, Firefox,
and WebKit, mirroring the existing local-proxy pattern used by
ClientCertificatesProxy.

Fixes: microsoft#10567
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2026

Test results for "tests 1"

41821 passed, 850 skipped

Merge workflow run.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2026

Test results for "MCP"

6 failed
❌ [firefox] › mcp/annotate.spec.ts:367 › should cancel browser_annotate when the MCP request is aborted @mcp-windows-latest-firefox
❌ [firefox] › mcp/cli-cookies.spec.ts:46 › cookie-list shows cookies @mcp-windows-latest-firefox
❌ [firefox] › mcp/cli-cookies.spec.ts:61 › cookie-delete removes cookie @mcp-windows-latest-firefox
❌ [msedge] › mcp/annotate.spec.ts:330 › should annotate when context has no fixed viewport @mcp-windows-latest-msedge
❌ [msedge] › mcp/annotate.spec.ts:367 › should cancel browser_annotate when the MCP request is aborted @mcp-windows-latest-msedge
❌ [webkit] › mcp/annotate.spec.ts:273 › should enter annotate mode on fresh dashboard.tsx mount with -s --annotate @mcp-windows-latest-webkit

7080 passed, 1104 skipped

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature] Support socks5 proxy with authentication

1 participant

@pavelfeldman