fix(test): import EventEmitter from 'events', not 'stream'#40872
Merged
Conversation
`EventEmitter` is the documented named export of `node:events`. It is not part of the documented public surface of `node:stream` — Node's CJS interop happens to expose it transitively, but strict ESM analyzers (e.g. Bun) reject the import as 'export not found'. Switching the import keeps behavior identical on Node and unblocks runtimes that perform strict ESM static analysis.
Contributor
Test results for "MCP"2 failed 7097 passed, 1104 skipped Merge workflow run. |
Contributor
Test results for "tests 1"5 flaky41909 passed, 850 skipped Merge workflow run. |
dgozman
approved these changes
May 18, 2026
Collaborator
dgozman
left a comment
dgozman
left a comment
There was a problem hiding this comment.
Looks good, thanks for the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EventEmitteris the documented named export ofnode:events. It is not part of the documented public surface ofnode:stream— Node's CJS interop happens to expose it transitively (becausestream's prototype chain reachesEventEmitter), but strict ESM analyzers reject the import statically as 'export not found'.Switching
packages/playwright/src/runner/watchMode.tsto import from'events'keeps behavior identical on Node and lets strict-analysis runtimes load the test runner without choking on this import.