Skip to content

Use more-specific types for test results and diagnostics.#15387

Merged
ericsnowcurrently merged 19 commits intomicrosoft:mainfrom
ericsnowcurrently:testing-results-final-test-status
Feb 17, 2021
Merged

Use more-specific types for test results and diagnostics.#15387
ericsnowcurrently merged 19 commits intomicrosoft:mainfrom
ericsnowcurrently:testing-results-final-test-status

Conversation

@ericsnowcurrently
Copy link
Copy Markdown

(for #14866)

Some of the problems we've run into relate to how we are using the same broad types for all the different kinds of test results (passing, failing, active and unknown). This change addresses that by switching to specific types tailored to the relevant kinds of test results.

Note: I will be updating for eslint once reviews are done.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 11, 2021

Codecov Report

Merging #15387 (dd97ae8) into main (a2cefcc) will decrease coverage by 0%.
The diff coverage is 57%.

@@          Coverage Diff           @@
##            main   #15387   +/-   ##
======================================
- Coverage     65%      65%   -1%     
======================================
  Files        560      561    +1     
  Lines      26912    26924   +12     
  Branches    3896     3901    +5     
======================================
- Hits       17523    17521    -2     
- Misses      8666     8679   +13     
- Partials     723      724    +1     
Impacted Files Coverage Δ
src/client/common/configSettings.ts 68% <ø> (ø)
src/client/common/startPage/startPage.ts 30% <ø> (-1%) ⬇️
src/client/common/types.ts 100% <ø> (ø)
src/client/telemetry/index.ts 77% <ø> (ø)
src/client/testing/common/argumentsHelper.ts 83% <ø> (ø)
src/client/testing/common/constants.ts 100% <ø> (ø)
src/client/testing/common/debugLauncher.ts 90% <ø> (ø)
...nt/testing/common/services/configSettingService.ts 90% <ø> (ø)
...c/client/testing/common/services/storageService.ts 15% <ø> (ø)
src/client/testing/common/testVisitors/visitor.ts 41% <ø> (ø)
... and 56 more

@ericsnowcurrently ericsnowcurrently force-pushed the testing-results-final-test-status branch from 52512de to 1eb4538 Compare February 17, 2021 00:46
@ericsnowcurrently ericsnowcurrently force-pushed the testing-results-final-test-status branch from 1eb4538 to dd97ae8 Compare February 17, 2021 22:25
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 57.89474% with 96 lines in your changes missing coverage. Please review.
✅ Project coverage is 65%. Comparing base (a2cefcc) to head (dd97ae8).
⚠️ Report is 2512 commits behind head on main.

Files with missing lines Patch % Lines
...ient/testing/pytest/services/testMessageService.ts 1% 53 Missing ⚠️
.../client/testing/common/managers/baseTestManager.ts 43% 13 Missing ⚠️
src/client/testing/main.ts 28% 10 Missing ⚠️
...esting/common/managers/testConfigurationManager.ts 54% 5 Missing ⚠️
src/client/testing/common/types.ts 88% 5 Missing ⚠️
src/client/testing/pytest/runner.ts 0% 2 Missing ⚠️
src/client/activation/jedi.ts 50% 1 Missing ⚠️
src/client/activation/jedi/languageServerProxy.ts 50% 1 Missing ⚠️
src/client/activation/node/languageServerProxy.ts 50% 1 Missing ⚠️
src/client/common/installer/productPath.ts 50% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #15387   +/-   ##
======================================
- Coverage     65%      65%   -1%     
======================================
  Files        560      561    +1     
  Lines      26912    26924   +12     
  Branches    3896     3901    +5     
======================================
- Hits       17523    17521    -2     
- Misses      8666     8679   +13     
- Partials     723      724    +1     
Files with missing lines Coverage Δ
...t/activation/languageServer/languageServerProxy.ts 90% <100%> (ø)
src/client/common/application/types.ts 100% <100%> (ø)
src/client/common/configSettings.ts 68% <ø> (ø)
src/client/common/serviceRegistry.ts 100% <100%> (ø)
src/client/common/startPage/startPage.ts 30% <ø> (-1%) ⬇️
src/client/common/types.ts 100% <ø> (ø)
src/client/telemetry/index.ts 77% <ø> (ø)
src/client/testing/codeLenses/testFiles.ts 16% <100%> (ø)
src/client/testing/common/argumentsHelper.ts 83% <ø> (ø)
src/client/testing/common/constants.ts 100% <ø> (ø)
... and 51 more

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants