Use more-specific types for test results and diagnostics.#15387
Merged
ericsnowcurrently merged 19 commits intomicrosoft:mainfrom Feb 17, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #15387 +/- ##
======================================
- Coverage 65% 65% -1%
======================================
Files 560 561 +1
Lines 26912 26924 +12
Branches 3896 3901 +5
======================================
- Hits 17523 17521 -2
- Misses 8666 8679 +13
- Partials 723 724 +1
|
kimadeline
reviewed
Feb 11, 2021
kimadeline
approved these changes
Feb 12, 2021
karthiknadig
approved these changes
Feb 12, 2021
52512de to
1eb4538
Compare
This reverts commit 254c847.
1eb4538 to
dd97ae8
Compare
This was referenced Jun 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(for #14866)
Some of the problems we've run into relate to how we are using the same broad types for all the different kinds of test results (passing, failing, active and unknown). This change addresses that by switching to specific types tailored to the relevant kinds of test results.
Note: I will be updating for eslint once reviews are done.