Fix type safeness of executeCommand#16383
Merged
jakebailey merged 4 commits intomicrosoft:mainfrom Jun 4, 2021
Merged
Conversation
Member
Author
|
See why this was changed, now; there's a cycle due to where the types were defined in #15387. Better to break the cycle by moving constants, IMO. |
Member
Author
|
Well, this turned a little gross. |
kimadeline
approved these changes
Jun 4, 2021
karthiknadig
approved these changes
Jun 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#15387 changed how this worked, but left things in a state where commands were no longer statically validated; the constraints were removed from the general command interface, which everyone else uses. A new interface was added that maintained the type safeness, but that wasn't used anywhere (other than during DI registration, which doesn't actually do anything).
Revert the change, and then fix all of the new commands that were added after so they can be checked.
Split out from #16374, where I discovered this when changing
installExtension.