enable/disable linting command#15162
Merged
ericsnowcurrently merged 5 commits intomicrosoft:mainfrom Jan 26, 2021
henryboisdequin:main
Merged
enable/disable linting command#15162ericsnowcurrently merged 5 commits intomicrosoft:mainfrom henryboisdequin:main
ericsnowcurrently merged 5 commits intomicrosoft:mainfrom
henryboisdequin:main
Conversation
kimadeline
suggested changes
Jan 18, 2021
kimadeline
left a comment
There was a problem hiding this comment.
Thank you for your contribution :)
The change looks good to me, however tests are failing, if you could take a look at them it would be great! Make sure you update the test suite in src/test/linters/linterCommands.unit.test.ts to reflect the change in wording as well.
Codecov Report
@@ Coverage Diff @@
## main #15162 +/- ##
======================================
Coverage 65% 65%
======================================
Files 561 561
Lines 26542 26542
Branches 3806 3806
======================================
Hits 17278 17278
Misses 8561 8561
Partials 703 703
|
kimadeline
approved these changes
Jan 19, 2021
kimadeline
left a comment
There was a problem hiding this comment.
Thank you for making the changes! Remember to add a news entry and thank yourself 🙂
kimadeline
approved these changes
Jan 20, 2021
Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>
kimadeline
approved these changes
Jan 21, 2021
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15162 +/- ##
======================================
Coverage 65% 65%
======================================
Files 561 560 -1
Lines 26542 26555 +13
Branches 3806 3813 +7
======================================
+ Hits 17278 17289 +11
+ Misses 8561 8560 -1
- Partials 703 706 +3
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #8800