Skip to content

enable/disable linting command#15162

Merged
ericsnowcurrently merged 5 commits intomicrosoft:mainfrom
henryboisdequin:main
Jan 26, 2021
Merged

enable/disable linting command#15162
ericsnowcurrently merged 5 commits intomicrosoft:mainfrom
henryboisdequin:main

Conversation

@henryboisdequin
Copy link
Copy Markdown

For #8800

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • The wiki is updated with any design decisions/details.

@ghost
Copy link
Copy Markdown

ghost commented Jan 17, 2021

CLA assistant check
All CLA requirements met.

Copy link
Copy Markdown

@kimadeline kimadeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution :)

The change looks good to me, however tests are failing, if you could take a look at them it would be great! Make sure you update the test suite in src/test/linters/linterCommands.unit.test.ts to reflect the change in wording as well.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #15162 (bd2a3a6) into main (b155be4) will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##            main   #15162   +/-   ##
======================================
  Coverage     65%      65%           
======================================
  Files        561      561           
  Lines      26542    26542           
  Branches    3806     3806           
======================================
  Hits       17278    17278           
  Misses      8561     8561           
  Partials     703      703           
Impacted Files Coverage Δ
src/client/linters/linterCommands.ts 82% <100%> (ø)

@kimadeline kimadeline self-requested a review January 19, 2021 18:11
Copy link
Copy Markdown

@kimadeline kimadeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes! Remember to add a news entry and thank yourself 🙂

Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>
Copy link
Copy Markdown

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericsnowcurrently ericsnowcurrently merged commit a5053a6 into microsoft:main Jan 26, 2021
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65%. Comparing base (b155be4) to head (10b0281).
⚠️ Report is 2611 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff           @@
##            main   #15162   +/-   ##
======================================
  Coverage     65%      65%           
======================================
  Files        561      560    -1     
  Lines      26542    26555   +13     
  Branches    3806     3813    +7     
======================================
+ Hits       17278    17289   +11     
+ Misses      8561     8560    -1     
- Partials     703      706    +3     
Files with missing lines Coverage Δ
src/client/linters/linterCommands.ts 82% <100%> (ø)

... and 17 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants