Avoid leaking listeners in notebook search results#319130
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Replaces manual IDisposable handles for notebook editor widget listeners with MutableDisposable registered to the parent disposable store, ensuring listeners are properly cleaned up when widgets are re-attached and on disposal.
Changes:
- Switched
_onWillChangeModelListenerand_onDidChangeModelListenerfromIDisposable | undefinedtoMutableDisposableregistered viathis._register. - Removed manual
?.dispose()calls at reassignment sites and indispose()sinceMutableDisposable.value =handles prior disposal.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/search/browser/searchTreeModel/searchResult.ts | Use MutableDisposable for notebook widget model-change listeners to avoid leaks. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
aiday-mar
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.