fix(install): defer success message until post-install checks#6098
Open
AMDphreak wants to merge 1 commit intomicrosoft:masterfrom
Open
fix(install): defer success message until post-install checks#6098AMDphreak wants to merge 1 commit intomicrosoft:masterfrom
AMDphreak wants to merge 1 commit intomicrosoft:masterfrom
Conversation
- Add DeferInstallSuccessMessage, PendingDeferredInstallSuccess, and SuppressDeferredInstallSuccess context flags. - InstallPackageInstaller defers reporting until after ReportARPChanges, RecordInstall, and DisplayInstallationNotes. - ReportInstallerResult, MsixInstall, and MS Store handlers honor defer; MSIX registration-deferred path suppresses generic success. - ReportDeferredInstallSuccess avoids spurious success when the installer did not complete (e.g. lock cancellation). Made-with: Cursor
Member
|
I don't agree with this change; the install was successful so we message that out. If we fail to do our own bookkeeping that can result in a failure of the overall operation, but the package install has already concluded. There can certainly be downstream problems created by that post-install failure, but any remediation would not involve re-running the package install. If there is a real issue that arises here I would prefer to see a comprehensive solution to handling post-operation failures. This change will end up making it look like the user request was not satisfied, when it is instead much closer to not getting a receipt with your purchase. |
JohnMcPMS
added
the
Needs-Author-Feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Delays the Successfully installed / repair success line until after post-install work runs (ARP snapshot correlation, upgrade version verification, record install, installation notes).
Details
DeferInstallSuccessMessage,PendingDeferredInstallSuccess,SuppressDeferredInstallSuccess.InstallPackageInstallersets defer, runs the existing pipeline, thenReportDeferredInstallSuccess.ReportInstallerResult,MsixInstall, and Microsoft Store install/update/repair paths respect defer; MSIX registration-deferred suppresses generic success (warning already shown).PendingDeferredInstallSuccessavoids printing success when the installer never completed (for example install lock cancelled before a success path).Related
Complements accurate reporting after install (for example ARP / version checks); avoids claiming success before those steps finish.
Testing
CI build; manual install scenarios recommended.
Made with Cursor
Microsoft Reviewers: Open in CodeFlow