Skip to content

ci(NODE-7593): switch off macos-13 to macos-26-intel#115

Merged
tadjik1 merged 2 commits into
mainfrom
node-7593
Jun 8, 2026
Merged

ci(NODE-7593): switch off macos-13 to macos-26-intel#115
tadjik1 merged 2 commits into
mainfrom
node-7593

Conversation

@PavelSafronov
Copy link
Copy Markdown
Contributor

@PavelSafronov PavelSafronov commented Jun 3, 2026

Description

Summary of Changes

macos-13 support was dropped (https://github.blog/changelog/2025-09-19-github-actions-macos-13-runner-image-is-closing-down/), so to continue testing Intel Mac, we're switching over to macos-15-intel, the closest comparable non-large runner.

Notes for Reviewers

What is the motivation for this change?

Current runner is deprecated, all PRs get stuck.

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@PavelSafronov PavelSafronov marked this pull request as ready for review June 3, 2026 19:52
@PavelSafronov PavelSafronov requested a review from a team as a code owner June 3, 2026 19:52
Copilot AI review requested due to automatic review settings June 3, 2026 19:52
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GitHub Actions workflow matrices to stop using the deprecated macos-13 runner image and continue running CI on an Intel macOS runner.

Changes:

  • Replace macos-13 with macos-15-intel in the test workflow OS matrix.
  • Replace macos-13 with macos-15-intel in the build workflow OS matrix.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/test.yml Updates the host test matrix to run on macos-15-intel instead of macos-13.
.github/workflows/build.yml Updates the host build/test matrix to run on macos-15-intel instead of macos-13.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tadjik1 tadjik1 self-assigned this Jun 5, 2026
@tadjik1 tadjik1 added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 5, 2026
Copy link
Copy Markdown
Contributor

@tadjik1 tadjik1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PavelSafronov thanks for looking into this issue!
What is the reason we run on macos-15-intel (quite old), and not, for example macos-26-intel?

@PavelSafronov
Copy link
Copy Markdown
Contributor Author

@PavelSafronov thanks for looking into this issue! What is the reason we run on macos-15-intel (quite old), and not, for example macos-26-intel?

Looked into this, and there isn't a good reason to not choose 26: 26 is going to be the last version to run on the supported hardware, so it's the OS that is the most representative of real remaining Intel users. Switching to 26.

Copy link
Copy Markdown
Contributor

@tadjik1 tadjik1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @PavelSafronov! 🥇

@tadjik1 tadjik1 merged commit 0adc87c into main Jun 8, 2026
31 checks passed
@tadjik1 tadjik1 deleted the node-7593 branch June 8, 2026 07:26
@tadjik1 tadjik1 changed the title ci(NODE-7593): switch off macos-13 to macos-15-intel ci(NODE-7593): switch off macos-13 to macos-26-intel Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants