refactor(frontend): extract full-page loading screen controller (@hunterpaulson)#7697
Open
hunterpaulson wants to merge 1 commit intomonkeytypegame:masterfrom
Open
Conversation
Member
|
hi @hunterpaulson, thank you for your contribution. Do you already have a use-case in mind? |
Author
f9eedb8 to
e5ba52f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
page-controllerinto a dedicatedloading-screencontrollerpage-controllerto use the extracted helperWhy
The full-page loading screen logic was previously embedded inside
page-controller, which made it harder to reuse outside route transitions.This refactor keeps the current behavior the same while moving the loading-screen orchestration into a dedicated controller so future non-routing flows (e.g. funboxes) can reuse the same loading UI without duplicating controller internals.
Validation
pnpm ts-checkpnpm lint-fast "src/ts/controllers/loading-screen.ts" "src/ts/controllers/page-controller.ts"