refactor(schemas): centralize regex constants (@byseif21, @fehmer)#7710
Open
byseif21 wants to merge 8 commits intomonkeytypegame:masterfrom
Open
refactor(schemas): centralize regex constants (@byseif21, @fehmer)#7710byseif21 wants to merge 8 commits intomonkeytypegame:masterfrom
byseif21 wants to merge 8 commits intomonkeytypegame:masterfrom
Conversation
monkeytypegeorge
added
frontend
github-actions
bot
added
the
waiting for review
Contributor
There was a problem hiding this comment.
Pull request overview
Centralizes commonly used regex patterns in @monkeytype/schemas and updates schema/frontend validators to reference shared constants instead of duplicating inline regexes.
Changes:
- Add shared
NAME_REGEX/SLUG_REGEXconstants inpackages/schemas/src/util.ts. - Replace multiple inline
.regex(/.../)usages across schema files with the centralized constants. - Update frontend username validation to use
SLUG_REGEXfrom schemas.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/schemas/src/util.ts | Introduces shared regex constants. |
| packages/schemas/src/users.ts | Swaps multiple validators to use shared regex constants. |
| packages/schemas/src/presets.ts | Uses shared regex for preset name validation. |
| packages/schemas/src/ape-keys.ts | Uses shared slug regex for ApeKey names. |
| frontend/src/ts/utils/misc.ts | Reuses shared slug regex for username validity check. |
Contributor
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
github-actions
bot
added
waiting for update
github-actions
bot
removed
the
waiting for update
fehmer
reviewed
Mar 23, 2026
fehmer
reviewed
Mar 23, 2026
byseif21
changed the title
byseif21
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.