fix(config): block monkey with live text stats (@d1rshan)#7715
Open
d1rshan wants to merge 3 commits intomonkeytypegame:masterfrom
Open
fix(config): block monkey with live text stats (@d1rshan)#7715d1rshan wants to merge 3 commits intomonkeytypegame:masterfrom
d1rshan wants to merge 3 commits intomonkeytypegame:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents unsupported UI config combinations that cause the monkey to overlap live stats when those stats use the text style, by blocking the conflicting settings at config-set time and notifying the user (closes #7714).
Changes:
- Add
isBlockedguards + notice toasts forliveSpeedStyle=text/liveAccStyle=textwhenmonkey=true, and for enablingmonkeywhen either live stat style istext. - Add setter-level tests verifying the blocked monkey/liveSpeedStyle combination triggers the expected notice.
- Add metadata-level tests covering blocked combinations for
monkey,liveSpeedStyle, andliveAccStyle.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| frontend/src/ts/config/metadata.ts | Adds isBlocked rules + user notices to prevent monkey + live text stats conflicts. |
| frontend/tests/root/config.spec.ts | Adds tests asserting setConfig rejects conflicting settings and emits the expected notice. |
| frontend/tests/root/config-metadata.spec.ts | Adds table-driven isBlocked coverage for the new conflict rules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents the invalid monkey + live text stats combination (monkey overlaps live speed / live accuracy)
This blocks:
Also adds tests for these blocked config combinations.
Closes #7714