Bug 2026043 - Require Option<T> for gecko-pref variables and require null defaults by default [ci full]#7296
Merged
freshstrangemusic merged 1 commit intomainfrom Mar 30, 2026
Conversation
relud
approved these changes
Mar 27, 2026
freshstrangemusic
force-pushed
the
freshstrangemusic/push-ltxnnkvwmxzr
branch
3 times, most recently
from
1a175bc to
b331361
Compare
freshstrangemusic
changed the title
freshstrangemusic
force-pushed
the
freshstrangemusic/push-ltxnnkvwmxzr
branch
3 times, most recently
from
ce496d2 to
5e95ed5
Compare
…null defaults by default In bug 2020683 we made the default field mutually exclusive with gecko-pref. However, this lead to another error, namely that gecko-pref was only valid for string, integer, and boolean types and `null` is not a valid value for these types. This issue lead to a backout in bug 2025587. This patch re-adds the requirement of null defaults for gecko-pref variables but also adds the requirement that these variables must be `Option<T>`, where `T` is a string, boolean, or integer. These constraints *can* be overridden by supplying the `--lax-gecko-pref-validation` flag to the `fml single-file`, `fml generate-experimenter`, and `fml validate` commands. This will allow Experimenter to continue to ingest manifests without error. Once the invalid manifest is ingested into Experimenter, we can manually edit the manifest to remove the invalid feature and eventually disable this validation mode.
freshstrangemusic
force-pushed
the
freshstrangemusic/push-ltxnnkvwmxzr
branch
from
5e95ed5 to
4a32756
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In bug 2020683 we made the default field mutually exclusive with gecko-pref. However, this lead to another error, namely that gecko-pref was only valid for string, integer, and boolean types and
nullis not a valid value for these types. This issue lead to a backout in bug 2025587.This patch re-adds the requirement of null defaults for gecko-pref variables but also adds the requirement that these variables must be
Option<T>, whereTis a string, boolean, or integer.These constraints can be overridden by supplying the
--lax-gecko-pref-validationflag to thefml single-file,fml generate-experimenter, andfml validatecommands. This will allow Experimenter to continue to ingest manifests without error.Once the invalid manifest is ingested into Experimenter, we can manually edit the manifest to remove the invalid feature and eventually disable this validation mode.
Pull Request checklist
[ci full]to the PR title.