osc.lua: make box layout default to fluent icons#17620
osc.lua: make box layout default to fluent icons#17620guidocella wants to merge 1 commit intompv-player:masterfrom
Conversation
Following up to 88e741a, because box layout is also more rounded than bar layouts, default it to fluent icons.
kasper93
left a comment
kasper93
left a comment
There was a problem hiding this comment.
LGTM, thanks!
This is a change to current box layout, but I think new icons are good fit for it, they are both rounded.
|
I consider this layout as a legacy, I personally hope it never changes. If it changed, would you consider to fix volume icon consistency? the size of speaker is not same between mute, low, normal, and high volume and does not keep on same position. |
|
Oh wow I see that, but it's a problem with the fluent volume icons in any layout. |
|
Fixed by #17753 |
I understand this sentiment. I feel like fluent icons are good fit for box, but not sure how to avoid making some users unhappy by changing them. Though, I've asked on IRC and the feedback was positive about changing. |
3 participants
Following up to 88e741a, because box layout is also more rounded than bar layouts, default it to fluent icons.