Skip to content

Share entries are updated, if available#13308

Closed
tobiasKaminsky wants to merge 1 commit intomasterfrom
fixShareUpdating
Closed

Share entries are updated, if available#13308
tobiasKaminsky wants to merge 1 commit intomasterfrom
fixShareUpdating

Conversation

@tobiasKaminsky
Copy link
Copy Markdown
Member

  • Tests written, or not not needed

@alperozturk96
Copy link
Copy Markdown
Collaborator

The actual bug has been resolved, but the share icon disappears at the 39th second. Then, at the 49th second, the share tab appears as if nothing has been shared before. However, this UI bug is disappears after the folder is refreshed.

share_broken.mp4

Copy link
Copy Markdown
Collaborator

@alperozturk96 alperozturk96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actual issue resolved but UI bugs still exists.

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@github-actions
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice4242
Correctness7474
Dodgy code276277
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3535
Performance4848
Security1818
Total503504

SpotBugs increased!

@github-actions
Copy link
Copy Markdown

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13308.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@alperozturk96
Copy link
Copy Markdown
Collaborator

@tobiasKaminsky Not valid after this PR: #15988.

DAO functions will be used.

@alperozturk96
Copy link
Copy Markdown
Collaborator

The actual issue fixed within FileDetailsSharingProcessFragment.kt. Can't able to reproduce the issue anymore.

Thus closing this PR to keep things organized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants