perf: gallery row holder caching#15902
Merged
tobiasKaminsky merged 4 commits intomasterfrom Nov 26, 2025
Merged
Conversation
alperozturk96
added
3. to review
performance 🚀
alperozturk96
added
don't merge
3. to review
and removed
2. developing
don't merge
labels
alperozturk96
force-pushed
the
perf/gallery-row-holder-caching
branch
3 times, most recently
from
796c7ea to
353cddd
Compare
AndyScherzinger
approved these changes
Nov 5, 2025
alperozturk96
force-pushed
the
perf/gallery-row-holder-caching
branch
2 times, most recently
from
a029245 to
fe6d432
Compare
alperozturk96
force-pushed
the
perf/gallery-row-holder-caching
branch
from
e89d7fd to
2dfdb76
Compare
alperozturk96
force-pushed
the
perf/gallery-row-holder-caching
branch
from
41d9ae9 to
8a198c3
Compare
tobiasKaminsky
previously requested changes
Nov 14, 2025
alperozturk96
force-pushed
the
perf/gallery-row-holder-caching
branch
from
8a198c3 to
7083630
Compare
Collaborator
Author
|
@tobiasKaminsky Could you please test this with your device? |
alperozturk96
force-pushed
the
perf/gallery-row-holder-caching
branch
from
7083630 to
a88ed84
Compare
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
alperozturk96
force-pushed
the
perf/gallery-row-holder-caching
branch
from
a88ed84 to
006fc5a
Compare
|
test-Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/15902-Unit-test-13-10 |
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15902.apk |
tobiasKaminsky
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Caches frequently used resources.
Avoids unnecessary object creation and minimizes layout recalculations.