Move or Copy files: Start in the parent folder instead of root#15925
Merged
alperozturk96 merged 4 commits intoDec 17, 2025
Conversation
PhilLab
force-pushed
the
move_or_copy_files_parent
branch
from
7ad5d3b to
283dd44
Compare
PhilLab
commented
Nov 8, 2025
Contributor
Author
|
Let me know if a ticket shall be created to track the behavior change |
PhilLab
force-pushed
the
move_or_copy_files_parent
branch
from
283dd44 to
35e3634
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
PhilLab
force-pushed
the
move_or_copy_files_parent
branch
from
35e3634 to
483d4e7
Compare
alperozturk96
requested changes
Dec 9, 2025
Collaborator
alperozturk96
left a comment
alperozturk96
left a comment
There was a problem hiding this comment.
Could you please take a look at this?
Then I’ll proceed with the test, and if everything looks good, we can merge it. Thank you.
PhilLab
force-pushed
the
move_or_copy_files_parent
branch
2 times, most recently
from
f341de9 to
04f9fef
Compare
alperozturk96
requested changes
Dec 11, 2025
PhilLab
force-pushed
the
move_or_copy_files_parent
branch
from
04f9fef to
bd9e6b2
Compare
PhilLab
force-pushed
the
move_or_copy_files_parent
branch
2 times, most recently
from
e31de0b to
302e268
Compare
Previous behavior always moved up to the root folder, which meant the user lost the context of their current files. Especially in complicated nested folder structures, this made standard operations overly complicated, like duplicating in the same folder or duplicating/moving to a sibling folder. This is now also in sync with the behavior of the iOS app and the web UI Signed-off-by: Philipp Hasper <[email protected]>
PhilLab
force-pushed
the
move_or_copy_files_parent
branch
2 times, most recently
from
31f4f30 to
385a89e
Compare
Last usage of the argument inside of the method was removed in 905222c, so removing it doesn't have any impact on the behavior. The only instance where the parameter was set to `true` was in the ExtendedListFragment Signed-off-by: Philipp Hasper <[email protected]>
Changing to OCFile? is required, as the parameter is indeed nullable. This didn't turn up prior to the rebase nor was it flagged in the pre-existing code, even though it is already an issue there. What probably happened is a combination of updated detection tools and the tools purposefully only flagging changed lines. Additionally, the nullness annotation was added to the underlying Java calls, to make sure the Kotlin type definition holds true. Signed-off-by: Philipp Hasper <[email protected]>
Minimal possible change to streamline the handling of this intent key. Alternatively, the class.java.simpleName or the !! operator could've been used at time of field definition. And the same would apply to several other places as well. Signed-off-by: Philipp Hasper <[email protected]>
alperozturk96
approved these changes
Dec 17, 2025
PhilLab
added a commit
to PhilLab/nextcloud-android
that referenced
this pull request
Dec 22, 2025
This tests the changes of nextcloud#15925, where the old behavior of moving up to the root folder was changed to stay in the parent folder of the file(s) to move/copy. The new behavior is in sync with iOS and the Web UI, hence this test ensures it doesn't break Signed-off-by: Philipp Hasper <[email protected]>
1 task
PhilLab
added a commit
to PhilLab/nextcloud-android
that referenced
this pull request
Dec 28, 2025
This tests the changes of nextcloud#15925, where the old behavior of moving up to the root folder was changed to stay in the parent folder of the file(s) to move/copy. The new behavior is in sync with iOS and the Web UI, hence this test ensures it doesn't break Signed-off-by: Philipp Hasper <[email protected]>
PhilLab
added a commit
that referenced
this pull request
Jan 15, 2026
This tests the changes of #15925, where the old behavior of moving up to the root folder was changed to stay in the parent folder of the file(s) to move/copy. The new behavior is in sync with iOS and the Web UI, hence this test ensures it doesn't break Signed-off-by: Philipp Hasper <[email protected]>
1 task
k0raph
pushed a commit
to k0raph/nextcloud-android
that referenced
this pull request
Jan 24, 2026
This tests the changes of nextcloud#15925, where the old behavior of moving up to the root folder was changed to stay in the parent folder of the file(s) to move/copy. The new behavior is in sync with iOS and the Web UI, hence this test ensures it doesn't break Signed-off-by: Philipp Hasper <[email protected]> Signed-off-by: Raphael Vieira <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous behavior always moved up to the root folder, which meant the user
lost the context of their current files. Especially in complicated nested
folder structures, this made standard operations overly complicated, like
duplicating in the same folder or duplicating/moving to a sibling folder.
This is now also in sync with the behavior of the iOS app and the web UI