fix: empty list state visibility#15976
Merged
Merged
Conversation
alperozturk96
force-pushed
the
fix/empty-list-state-visibility
branch
from
963ee4c to
f637539
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
alperozturk96
force-pushed
the
fix/empty-list-state-visibility
branch
from
f637539 to
8367d15
Compare
Signed-off-by: alperozturk <alper_ozturk@proton.me> # Conflicts: # app/src/main/java/com/owncloud/android/ui/fragment/ExtendedListFragment.kt # Conflicts: # app/src/main/java/com/owncloud/android/ui/adapter/OCFileListAdapter.java
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
alperozturk96
force-pushed
the
fix/empty-list-state-visibility
branch
from
1f3bce3 to
f1e59ec
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15976.apk |
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
If the adapter has data or adapter is null, the empty list should not be visible.
There is no need to update the empty view if its state hasn’t changed.
The empty view state must be checked after setting the adapter and via the adapter’s observer.