Skip to content

implementation "androidx.browser:browser:1.8.0"#16004

Closed
duvvuvenkataramana wants to merge 1 commit into
nextcloud:masterfrom
duvvuvenkataramana:patch-1
Closed

implementation "androidx.browser:browser:1.8.0"#16004
duvvuvenkataramana wants to merge 1 commit into
nextcloud:masterfrom
duvvuvenkataramana:patch-1

Conversation

@duvvuvenkataramana
Copy link
Copy Markdown
Contributor

  • Tests written, or not not needed

@duvvuvenkataramana
Copy link
Copy Markdown
Contributor Author

@AndyScherzinger Review this and merge

Copy link
Copy Markdown
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@duvvuvenkataramana see CI checks, this doesn't compile, see for example https://github.com/nextcloud/android/actions/runs/19671017003/job/56360672919?pr=16004#step:5:1061

Again, this feels fully vibe coded with a misleading PR title and code that doesn't event compile, hence no quality assurance, neither manual not automated even failing to compile and run.

@github-actions
Copy link
Copy Markdown

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants