implementation "androidx.browser:browser:1.8.0"#16004
implementation "androidx.browser:browser:1.8.0"#16004duvvuvenkataramana wants to merge 1 commit into
Conversation
duvvuvenkataramana
commented
Nov 25, 2025
- Tests written, or not not needed
Signed-off-by: duvvuvenkataramana <[email protected]>
|
@AndyScherzinger Review this and merge |
AndyScherzinger
left a comment
There was a problem hiding this comment.
@duvvuvenkataramana see CI checks, this doesn't compile, see for example https://github.com/nextcloud/android/actions/runs/19671017003/job/56360672919?pr=16004#step:5:1061
Again, this feels fully vibe coded with a misleading PR title and code that doesn't event compile, hence no quality assurance, neither manual not automated even failing to compile and run.
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |