Update strings.xml Fix typo in offline_operations_file_does_not_exists_yet value#16007
Update strings.xml Fix typo in offline_operations_file_does_not_exists_yet value#16007duvvuvenkataramana wants to merge 3 commits into
Conversation
…_yet value Corrects 'exists' to 'exist' in the string value. Signed-off-by: duvvuvenkataramana <[email protected]>
…_yet value Signed-off-by: duvvuvenkataramana <[email protected]>
|
Change looks good to me @duvvuvenkataramana |
|
First is having one mistake that's why corrected . That is second one |
|
@duvvuvenkataramana yes which is why, for a clean git history, if you squash the 2 commits into one there will be no mistake in any commit anymore. See for examples https://www.datacamp.com/tutorial/git-squash-commits on how to squash commits. |
|
If you don't have the tooling in place, no worries we can also squash them at merge time, just let me know (and I am waiting for @rakekniven's review) |
Signed-off-by: duvvuvenkataramana <[email protected]>
AndyScherzinger
left a comment
There was a problem hiding this comment.
The 3rd commit deletes the whole file and needs to be removed @duvvuvenkataramana ❗
|
Sorry sir I will close this one created new one |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
…_yet value
Corrects 'exists' to 'exist' in the string value.