Skip to content

Update strings.xml Fix typo in offline_operations_file_does_not_exists_yet value#16007

Closed
duvvuvenkataramana wants to merge 3 commits into
nextcloud:masterfrom
duvvuvenkataramana:patch-3
Closed

Update strings.xml Fix typo in offline_operations_file_does_not_exists_yet value#16007
duvvuvenkataramana wants to merge 3 commits into
nextcloud:masterfrom
duvvuvenkataramana:patch-3

Conversation

@duvvuvenkataramana
Copy link
Copy Markdown
Contributor

…_yet value

Corrects 'exists' to 'exist' in the string value.

  • Tests written, or not not needed

…_yet value

Corrects 'exists' to 'exist' in the string value.

Signed-off-by: duvvuvenkataramana <[email protected]>
@AndyScherzinger
Copy link
Copy Markdown
Member

Change looks good to me @duvvuvenkataramana
Can you please squash the commits into one given the second commit is a fix for the first commit? Thanks in advance 🙏

@AndyScherzinger AndyScherzinger changed the title Update strings.xmlFix typo in offline_operations_Fix typo in offline_operations_file_does_not_exists_yet valuefile_does_not_exists… Update strings.xml Fix typo in offline_operations_file_does_not_exists_yet value Nov 25, 2025
@duvvuvenkataramana
Copy link
Copy Markdown
Contributor Author

First is having one mistake that's why corrected . That is second one
Review and merge the PR

@AndyScherzinger
Copy link
Copy Markdown
Member

@duvvuvenkataramana yes which is why, for a clean git history, if you squash the 2 commits into one there will be no mistake in any commit anymore. See for examples https://www.datacamp.com/tutorial/git-squash-commits on how to squash commits.

@AndyScherzinger
Copy link
Copy Markdown
Member

If you don't have the tooling in place, no worries we can also squash them at merge time, just let me know (and I am waiting for @rakekniven's review)

Copy link
Copy Markdown
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 3rd commit deletes the whole file and needs to be removed @duvvuvenkataramana

@duvvuvenkataramana
Copy link
Copy Markdown
Contributor Author

Sorry sir I will close this one created new one

@github-actions
Copy link
Copy Markdown

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants