Skip to content

fix: screenshot tests logic#16023

Merged
alperozturk96 merged 12 commits into
masterfrom
fix/screenshot-test-logic
Dec 3, 2025
Merged

fix: screenshot tests logic#16023
alperozturk96 merged 12 commits into
masterfrom
fix/screenshot-test-logic

Conversation

@alperozturk96
Copy link
Copy Markdown
Collaborator

@alperozturk96 alperozturk96 commented Nov 27, 2025

  • Tests written, or not not needed

@alperozturk96 alperozturk96 force-pushed the fix/screenshot-test-logic branch from 442a000 to f534e52 Compare November 27, 2025 10:18
@alperozturk96 alperozturk96 linked an issue Nov 27, 2025 that may be closed by this pull request
4 tasks
@alperozturk96 alperozturk96 changed the title fix: screenshot tests fix: screenshot tests logic Nov 27, 2025
@alperozturk96 alperozturk96 force-pushed the fix/screenshot-test-logic branch from b94b22f to 465794c Compare November 28, 2025 07:08
@alperozturk96
Copy link
Copy Markdown
Collaborator Author

@tobiasKaminsky

How can we fix this?

Screenshot 2025-11-28 at 08 54 11

@alperozturk96 alperozturk96 force-pushed the fix/screenshot-test-logic branch 2 times, most recently from 668fa33 to 66d6816 Compare December 2, 2025 15:15
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>

# Conflicts:
#	app/src/androidTest/java/com/owncloud/android/ui/fragment/SharedListFragmentIT.kt
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 alperozturk96 force-pushed the fix/screenshot-test-logic branch from 66d6816 to 4f9ca16 Compare December 3, 2025 12:04
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 3, 2025

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 3, 2025

Codacy

SpotBugs

CategoryBaseNew
Bad practice4343
Correctness7474
Dodgy code268268
Experimental11
Internationalization77
Malicious code vulnerability33
Multithreaded correctness3434
Performance4848
Security1818
Total496496

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 3, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16023.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 3, 2025

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@alperozturk96
Copy link
Copy Markdown
Collaborator Author

The EventBus handling still needs to be addressed for the tests. Since this issue is also blocking the master branch and the screenshot tests are consistently bypassing the inner assertions, I will proceed with merging this PR.

Screenshot 2025-12-03 at 14 58 30

@alperozturk96 alperozturk96 merged commit 4a876f0 into master Dec 3, 2025
16 of 21 checks passed
@alperozturk96 alperozturk96 deleted the fix/screenshot-test-logic branch December 3, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

InstrumentationTests don't fail when failure is expected

1 participant