Skip to content

fix: metadata photo size#16043

Merged
alperozturk96 merged 4 commits into
masterfrom
fix/metadata-photo-size
Dec 3, 2025
Merged

fix: metadata photo size#16043
alperozturk96 merged 4 commits into
masterfrom
fix/metadata-photo-size

Conversation

@alperozturk96
Copy link
Copy Markdown
Collaborator

@alperozturk96 alperozturk96 commented Dec 2, 2025

  • Tests written, or not not needed

Issue

The metadata-photo-size property is being overwritten by the gallery search task. This property is provided through the WebDAV API, and the application should not override it with incorrect or null values.

GallerySearchTask remote file:

Screenshot 2025-12-02 at 10 23 13

How to reproduce?

  1. Have image files
  2. Fresh install app
  3. Check filelist database table before opening media tab metadata_size column has correct data but after opening media tab it becomes null.
Screenshot 2025-12-02 at 10 33 22

}

// resized dimensions and set update thumbnail needed to false to prevent rendering loop
if (thumbnail != null) {
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not override actual image size with thumbnail size.

Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the fix/metadata-photo-size branch from 8849b62 to b21d7a6 Compare December 2, 2025 15:14
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 2, 2025

Codacy

SpotBugs

CategoryBaseNew
Bad practice4242
Correctness7474
Dodgy code267268
Experimental11
Internationalization77
Malicious code vulnerability33
Multithreaded correctness3434
Performance4848
Security1818
Total494495

SpotBugs increased!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 2, 2025

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@alperozturk96 alperozturk96 merged commit f4e1e91 into master Dec 3, 2025
15 of 21 checks passed
@alperozturk96 alperozturk96 deleted the fix/metadata-photo-size branch December 3, 2025 07:40
@alperozturk96 alperozturk96 added this to the Nextcloud App 3.35.0 milestone Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants