Skip to content

fix: upload cancel & remove#16048

Merged
alperozturk96 merged 2 commits into
masterfrom
fix/cancel-uploads
Dec 4, 2025
Merged

fix: upload cancel & remove#16048
alperozturk96 merged 2 commits into
masterfrom
fix/cancel-uploads

Conversation

@alperozturk96
Copy link
Copy Markdown
Collaborator

@alperozturk96 alperozturk96 commented Dec 3, 2025

  • Tests written, or not not needed

Changes

Fix cancel upload
Add remove upload

This update improves the handling of file uploads by clearly distinguishing between Cancel and Remove actions:

Cancel Upload:

  1. Stops the current upload in progress.
  2. Marks the upload as cancelled.
  3. The upload remains visible in the upload list.
  4. On app restart, cancelled uploads automatically resume.

Remove Upload:

  1. Deletes the upload from the upload list entirely.
  2. The file will never be uploaded again.

These two actions provide necessary functionality for managing uploads, especially in cases such as SYNC_CONFLICT, where users need to either resolve the conflict or remove the upload.

This update also ensures that users can clearly distinguish between cancelling an upload and permanently removing it, reducing confusion and improving overall upload management.


How can we make it easier for users to understand the difference between these two actions? @kra-mo

Screenshot_20251203_101634

Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 4, 2025

Codacy

SpotBugs

CategoryBaseNew
Bad practice4343
Correctness7474
Dodgy code265265
Experimental11
Internationalization77
Malicious code vulnerability33
Multithreaded correctness3434
Performance4848
Security1818
Total493493

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 4, 2025

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 4, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16048.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@alperozturk96 alperozturk96 merged commit 2d89180 into master Dec 4, 2025
13 of 20 checks passed
@alperozturk96 alperozturk96 deleted the fix/cancel-uploads branch December 4, 2025 12:14
@kra-mo
Copy link
Copy Markdown
Member

kra-mo commented Dec 4, 2025

How can we make it easier for users to understand the difference between these two actions?

I guess this is merged now, but more accurate terms would be:

Cancel → Pause and
Remove → Cancel

as "cancel" sounds final.

@kra-mo
Copy link
Copy Markdown
Member

kra-mo commented Dec 4, 2025

Although the first one could also be called "Stop" and the second could remain "Remove". Whatever you think makes more sense with the rest of the feature's existing wording.

@alperozturk96
Copy link
Copy Markdown
Collaborator Author

@kra-mo I will create another PR for that, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants