Skip to content

fix: update file download limit#16059

Merged
alperozturk96 merged 5 commits into
masterfrom
fix/update-file-download-limit
Dec 9, 2025
Merged

fix: update file download limit#16059
alperozturk96 merged 5 commits into
masterfrom
fix/update-file-download-limit

Conversation

@alperozturk96
Copy link
Copy Markdown
Collaborator

@alperozturk96 alperozturk96 commented Dec 4, 2025

  • Tests written, or not not needed

Issue: #16039

@alperozturk96 alperozturk96 added this to the Nextcloud App 3.35.0 milestone Dec 4, 2025
@alperozturk96 alperozturk96 linked an issue Dec 4, 2025 that may be closed by this pull request
4 tasks
@alperozturk96 alperozturk96 force-pushed the fix/update-file-download-limit branch 4 times, most recently from cc30ebe to daf2026 Compare December 8, 2025 08:44
@mpivchev
Copy link
Copy Markdown
Contributor

mpivchev commented Dec 8, 2025

Trying to add share to this file:

image

Title shows ROOT instead of the name of the file?
Also, the download limit option is not visible:

image

@alperozturk96 alperozturk96 force-pushed the fix/update-file-download-limit branch from daf2026 to c4ccea7 Compare December 9, 2025 10:00
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Copy link
Copy Markdown
Collaborator Author

/backport to stable-3.35

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 9, 2025

Codacy

SpotBugs

CategoryBaseNew
Bad practice4343
Correctness7474
Dodgy code260260
Experimental11
Internationalization77
Malicious code vulnerability33
Multithreaded correctness3434
Performance4848
Security1818
Total488488

)
}

private fun toggleNextButtonAvailability(value: Boolean) {
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User can always update current share just like iOS and Web

return
}

if (!isSharePermissionChecked() && !isCustomPermissionSelectedAndAnyCustomPermissionTypeChecked()) {
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User can always update current share just like iOS and Web

@alperozturk96 alperozturk96 merged commit 2ef4188 into master Dec 9, 2025
18 of 21 checks passed
@alperozturk96 alperozturk96 deleted the fix/update-file-download-limit branch December 9, 2025 11:13
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 9, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16059.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 9, 2025

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Download limit resets when changing anything in a link share

2 participants