change upload buttons wording

[alperozturk96]

• Tests written, or not not needed

[AndyScherzinger]

Hmm, just checked Firefox, and they also use "cancel" not "stop"

[kra-mo]

I mean, another data point: Safari says "stop". I just think that in our case, stop or pause makes more sense as it will be resumed later, cancel really implies "don't do this" to me.

[kra-mo]

Chrome has Pause and Cancel as well, Cancel for removing it.

[kra-mo]

Right, and I mean Firefox doesn't have a separate way to remove the download either. And after clicking on "Cancel", the option becomes "Retry", which seems weird and more like the result of a failure state imo.

[kra-mo]

Fair enough. I'm leaning a bit more towards Pause and Cancel, especially after learning that Chrome does it but if you think this makes more sense, go ahead :)

[alperozturk96]

[github-actions]

Codacy

SpotBugs

Category	Base	New
Bad practice	43	43
Correctness	74	74
Dodgy code	260	260
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	3	3
Multithreaded correctness	34	34
Performance	48	48
Security	18	18
Total	488	488

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16062.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions]

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.