fix: group folder adapter crash

[alperozturk96]

• Tests written, or not not needed

Issue

Navigate to group folder tab crash

E  FATAL EXCEPTION: main
                                                                                                   Process: com.nextcloud.client, PID: 4625
                                                                                                   kotlin.UninitializedPropertyAccessException: lateinit property list has not been initialized
                                                                                                   	at com.owncloud.android.ui.adapter.GroupFolderListAdapter.getList(GroupFolderListAdapter.kt:30)
                                                                                                   	at com.owncloud.android.ui.adapter.GroupFolderListAdapter.getItemCount(GroupFolderListAdapter.kt:46)
                                                                                                   	at com.owncloud.android.ui.EmptyRecyclerView.configureEmptyView(EmptyRecyclerView.kt:53)
                                                                                                   	at com.owncloud.android.ui.EmptyRecyclerView.setAdapter(EmptyRecyclerView.kt:33)
                                                                                                   	at com.owncloud.android.ui.fragment.ExtendedListFragment.setRecyclerViewAdapter(ExtendedListFragment.kt:137)
                                                                                                   	at com.owncloud.android.ui.fragment.GroupfolderListFragment.setAdapter(GroupfolderListFragment.kt:59)
                                                                                                   	at com.owncloud.android.ui.fragment.OCFileListFragment.onActivityCreated(OCFileListFragment.java:390)
                                                                                                   	at com.owncloud.android.ui.fragment.GroupfolderListFragment.onActivityCreated(GroupfolderListFragment.kt:48)
                                                                                                   	at androidx.fragment.app.Fragment.performActivityCreated(Fragment.java:3161)
                                                                                                   	at androidx.fragment.app.FragmentStateManager.activityCreated(FragmentStateManager.java:639)
                                                                                                   	at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:289)
                                                                                                   	at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:2214)
                                                                                                   	at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:2109)
                                                                                                   	at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:2052)
                                                                                                   	at androidx.fragment.app.FragmentManager.executePendingTransactions(FragmentManager.java:779)
                                                                                                   	at com.owncloud.android.ui.activity.FileDisplayActivity.handleSpecialIntents(FileDisplayActivity.kt:575)
                                                                                                   	at com.owncloud.android.ui.activity.FileDisplayActivity.onNewIntent(FileDisplayActivity.kt:547)
                                                                                                   	at android.app.Activity.onNewIntent(Activity.java:2418)
                                                                                                   	at android.app.Activity.performNewIntent(Activity.java:9029)
                                                                                                   	at android.app.Instrumentation.callActivityOnNewIntent(Instrumentation.java:1646)
                                                                                                   	at android.app.Instrumentation.internalCallActivityOnNewIntent(Instrumentation.java:1667)
                                                                                                   	at android.app.Instrumentation.callActivityOnNewIntent(Instrumentation.java:1655)
                                                                                                   	at android.app.ActivityThread.deliverNewIntents(ActivityThread.java:4280)
                                                                                                   	at android.app.ActivityThread.handleNewIntent(ActivityThread.java:4290)
                                                                                                   	at android.app.servertransaction.NewIntentItem.execute(NewIntentItem.java:58)
                                                                                                   	at android.app.servertransaction.ActivityTransactionItem.execute(ActivityTransactionItem.java:60)
                                                                                                   	at android.app.servertransaction.TransactionExecutor.executeNonLifecycleItem(TransactionExecutor.java:174)
                                                                                                   	at android.app.servertransaction.TransactionExecutor.executeTransactionItems(TransactionExecutor.java:109)
                                                                                                   	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:81)
                                                                                                   	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2636)
                                                                                                   	at android.os.Handler.dispatchMessage(Handler.java:107)
                                                                                                   	at android.os.Looper.loopOnce(Looper.java:232)
                                                                                                   	at android.os.Looper.loop(Looper.java:317)
                                                                                                   	at android.app.ActivityThread.main(ActivityThread.java:8705)
                                                                                                   	at java.lang.reflect.Method.invoke(Native Method)
                                                                                                   	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:580)
                                                                                                   	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:886)

[github-actions]

Codacy

SpotBugs

Category	Base	New
Bad practice	43	43
Correctness	74	74
Dodgy code	260	260
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	3	3
Multithreaded correctness	34	34
Performance	48	48
Security	18	18
Total	488	488

[github-actions]

test-Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16066-Unit-test-08-45

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16066.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions]

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

[alperozturk96]

/backport to stable-3.35