fix(mimetype): Add TSV support in mimetype aliases, mapping, and names#61147
fix(mimetype): Add TSV support in mimetype aliases, mapping, and names#61147brlin-tw wants to merge 1 commit into
Conversation
Signed-off-by: 林博仁(Buo-ren Lin) <buo.ren.lin@gmail.com>
brlin-tw
requested review from
ArtificialOwl,
come-nc,
icewind1991 and
salmart-dev
and removed request for
a team
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f3799c8654
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "text/css": "text/code", | ||
| "text/csv": "x-office/spreadsheet", | ||
| "text/html": "text/code", | ||
| "text/tab-separated-values": "x-office/spreadsheet", |
There was a problem hiding this comment.
Adding this alias only updates the server-side JSON; the browser uses the tracked generated core/js/mimetypelist.js (window.OC.MimeTypeList.aliases/names) for file icons, type filters, and display names. This commit leaves that generated file unchanged (it still has text/csv but no text/tab-separated-values entry), so .tsv files detected as text/tab-separated-values will not get the spreadsheet alias or the new TSV name in the shipped UI until someone manually runs maintenance:mimetype:update-js.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
I believe this is not a problem in the source code form.
2 participants
Summary
This pull requests adds definitions for the text/tab-separated-values mime type.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)