Skip to content

update: drop number of vulnerabilities on --pre-release#1080

Open
RafaelGSS wants to merge 2 commits into
mainfrom
drop-vuln-number-prerelease
Open

update: drop number of vulnerabilities on --pre-release#1080
RafaelGSS wants to merge 2 commits into
mainfrom
drop-vuln-number-prerelease

Conversation

@RafaelGSS
Copy link
Copy Markdown
Member

When we announce a security release, we typically say we'll be fixing X High, X Medium, and so on. That policy was set before the AI era, when reports weren't as frequent.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2026

Codecov Report

❌ Patch coverage is 98.59155% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 65.02%. Comparing base (b6c1ff4) to head (da25653).

Files with missing lines Patch % Lines
lib/security_blog.js 97.22% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1080      +/-   ##
==========================================
- Coverage   71.72%   65.02%   -6.70%     
==========================================
  Files          41       45       +4     
  Lines        5895     6973    +1078     
==========================================
+ Hits         4228     4534     +306     
- Misses       1667     2439     +772     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RafaelGSS RafaelGSS force-pushed the drop-vuln-number-prerelease branch from 5e07124 to 6b726e9 Compare May 26, 2026 12:53
Comment thread lib/security-release/security-release.js Outdated
Comment thread lib/security-release/security-release.js Outdated
@RafaelGSS
Copy link
Copy Markdown
Member Author

It seems C8 no longer works on Node.js v26

@aduh95
Copy link
Copy Markdown
Contributor

aduh95 commented May 26, 2026

I've opened #1081 to fix that

@marco-ippolito
Copy link
Copy Markdown
Member

marco-ippolito commented May 26, 2026

Can you verify the markdown template handles the new format?

@aduh95
Copy link
Copy Markdown
Contributor

aduh95 commented May 26, 2026

Can you verify the markdown template handles the new format?

Can you clarify what you mean? Which markdown template?

@marco-ippolito
Copy link
Copy Markdown
Member

marco-ippolito commented May 26, 2026

Can you verify the markdown template handles the new format?

Can you clarify what you mean? Which markdown template?

The output of that function replaces the placeholder %VULNERABILITIES in the prerelease accouncement markdown file

# Summary
The Node.js project will release new versions of the %AFFECTED_VERSIONS%
releases lines on or shortly after, %RELEASE_DATE% in order to address:
%VULNERABILITIES%

Comment thread lib/security_blog.js
RafaelGSS added 2 commits May 28, 2026 15:01
When we announce a security release, we typically say we'll be
fixing X High, X Medium, and so on. That policy was set before
the AI era, when reports weren't as frequent.

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@RafaelGSS RafaelGSS force-pushed the drop-vuln-number-prerelease branch from 966089e to da25653 Compare May 28, 2026 18:29
@RafaelGSS
Copy link
Copy Markdown
Member Author

PTAL @aduh95 @marco-ippolito

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants