test: wait for ok before initial break after restart

[inoway46]

Follow-up to: #62471

Waiting for Debugger attached. before waitForInitialBreak() reduced one race, but it still was not a strong enough sync point. During reconnect, debug> can be re-displayed before the CLI finishes run()/restart(), and the output can still look like:

Debugger attached.
debug>
ok
debug>

This change waits for ok before waitForInitialBreak(), so the test only starts waiting for the initial break after the CLI has completed reconnecting.

CI logs

• https://github.com/nodejs/node/actions/runs/24588065778
• https://github.com/nodejs/node/actions/runs/24600780762

Testing

UNUSUAL="$HOME/dir with \$unusual\"chars?'åß∂ƒ©∆¬…\`"
mkdir -p "$UNUSUAL"
ln -sfn "$PWD" "$UNUSUAL/node"
cd "$UNUSUAL/node"

• ./tools/test.py -p actions -j1 --repeat 50 parallel/test-debugger-run-after-quit-restart

Refs: #61762

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.05%. Comparing base (6916e64) to head (81cf8e7).
⚠️ Report is 28 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #62807      +/-   ##
==========================================
- Coverage   90.05%   90.05%   -0.01%     
==========================================
  Files         714      714              
  Lines      225242   225242              
  Branches    42579    42580       +1     
==========================================
- Hits       202843   202838       -5     
- Misses      14187    14193       +6     
+ Partials     8212     8211       -1     

see 28 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/72790/

[inoway46]

#62807 (comment)
This failure seems unrelated to this PR. Could someone request CI again, please?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/72821/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/72829/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/72845/

[inoway46]

#62807 (comment)
https://ci.nodejs.org/job/node-test-commit-linux/69582/

I think this flaky has already been solved, so could someone rerun CI?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/73120/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/73130/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/73144/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/73258/

[inoway46]

@lpinca The latest full CI passed.

I missed the DCO sign-off:

Signed-off-by: inoway46 [email protected]

Could this be added during landing, or should I force-push it?

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/62807
✔  Done loading data for nodejs/node/pull/62807
----------------------------------- PR info ------------------------------------
Title      test: wait for ok before initial break after restart (#62807)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     inoway46:fix-flaky-wait-after-restart -> nodejs:main
Labels     test, needs-ci
Commits    1
 - test: wait for ok before initial break after restart
Committers 1
 - inoway46 <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/62807
Refs: https://github.com/nodejs/node/issues/61762
Reviewed-By: Luigi Pinca <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/62807
Refs: https://github.com/nodejs/node/issues/61762
Reviewed-By: Luigi Pinca <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 18 Apr 2026 17:38:56 GMT
   ✔  Approvals: 1
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/62807#pullrequestreview-4136535927
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-05-08T10:51:55Z: https://ci.nodejs.org/job/node-test-pull-request/73258/
- Querying data for job/node-test-pull-request/73258/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 62807
From https://github.com/nodejs/node
 * branch                  refs/pull/62807/merge -> FETCH_HEAD
✔  Fetched commits as 6009d937f515..3a7bcb0aadd1
--------------------------------------------------------------------------------
[main d258a47100] test: wait for ok before initial break after restart
 Author: inoway46 <[email protected]>
 Date: Sun Apr 19 02:29:40 2026 +0900
 1 file changed, 4 insertions(+), 2 deletions(-)
   ✔  Patches applied
--------------------------------------------------------------------------------
--------------------------------- New Message ----------------------------------
test: wait for ok before initial break after restart
PR-URL: #62807

Refs: #61762

Reviewed-By: Luigi Pinca <[email protected]>
[main d0856e5f85] test: wait for ok before initial break after restart

Author: inoway46 <[email protected]>

Date: Sun Apr 19 02:29:40 2026 +0900

1 file changed, 4 insertions(+), 2 deletions(-)

✖  d0856e5f85ca2f05a1ec64c0de4dc4d7ca5aa6a9

✔  0:0      no Assisted-by metadata                   assisted-by-is-trailer

✔  0:0      no Co-authored-by metadata                co-authored-by-is-trailer

✔  0:0      skipping fixes-url                        fixes-url

✔  0:0      blank line after title                    line-after-title

✔  0:0      line-lengths are valid                    line-length

✔  0:0      metadata is at end of message             metadata-end

✔  1:8      PR-URL is valid.                          pr-url

✔  0:0      reviewers are valid                       reviewers

✖  0:0      Commit must have a "Signed-off-by" trailer signed-off-by

✔  0:0      valid subsystems                          subsystem

✔  0:0      Title is formatted correctly.             title-format

⚠  0:50     Title should be <= 50 columns.            title-length
ℹ  Please fix the commit message and try again.

Please manually ammend the commit message, by running

git commit --amend

Once commit message is fixed, finish the landing command running

git node land --continue

https://github.com/nodejs/node/actions/runs/25750709415

[lpinca]

Could this be added during landing, or should I force-push it?

It looks like you have to add it and force-push :(

[inoway46]

@lpinca I force-pushed the signed-off commit, and the latest CI has passed.

Sorry for bothering you again, but could you request a full CI run when you have a chance?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/73492/