Skip to content

[v22.x backport] doc: remove obsolete Boxstarter automated install#63190

Open
MikeMcC399 wants to merge 1 commit intonodejs:v22.x-stagingfrom
MikeMcC399:backport-61785-to-v22.x
Open

[v22.x backport] doc: remove obsolete Boxstarter automated install#63190
MikeMcC399 wants to merge 1 commit intonodejs:v22.x-stagingfrom
MikeMcC399:backport-61785-to-v22.x

Conversation

@MikeMcC399
Copy link
Copy Markdown
Contributor

Backports #61785 to v22.x

PR-URL: #61785
Fixes: #61690
Reviewed-By: Richard Lau [email protected]
Reviewed-By: Colin Ihrig [email protected]
Reviewed-By: Marco Ippolito [email protected]
Reviewed-By: Stefan Stojanovic [email protected]
Reviewed-By: Tierney Cyren [email protected]
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Rafael Gonzaga [email protected]

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/build
  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels May 8, 2026
PR-URL: nodejs#61785
Fixes: nodejs#61690
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Signed-off-by: Mike McCready <[email protected]>
@MikeMcC399 MikeMcC399 force-pushed the backport-61785-to-v22.x branch from 9dd96ca to 73ec371 Compare May 8, 2026 11:18
@MikeMcC399
Copy link
Copy Markdown
Contributor Author

I have added

Signed-off-by: Mike McCready <[email protected]>

to satisfy linting, despite what it says in https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#step-4-commit that it is not required for backport commits.

@MikeMcC399 MikeMcC399 marked this pull request as ready for review May 8, 2026 11:20
@thisalihassan
Copy link
Copy Markdown
Contributor

@MikeMcC399 as per the backport rule I believe we should not change commit message also, it's fine to let if fail for now

This rule does not apply to dependency updates (e.g. cherry-picks), release
commits, or backport commits.

@MikeMcC399
Copy link
Copy Markdown
Contributor Author

@thisalihassan

Since I was the author also of the original PR that I am backporting, and at the time the original PR was submitted and landed there was no requirement for Signed-off-by, I'm fine to add this now as a workaround.

I've added a separate issue #63192 to clarify the linting / process problem.

I would only remove the Signed-off-by trailer if it causes an issue to leave it in and I defer to the backporters team for any instructions they want to give.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants