Skip to content

chore: add i18n redirect#2290

Merged
danielroe merged 2 commits intomainfrom
chore/i18n-redirect
Mar 27, 2026
Merged

chore: add i18n redirect#2290
danielroe merged 2 commits intomainfrom
chore/i18n-redirect

Conversation

@danielroe
Copy link
Copy Markdown
Member

🔗 Linked issue

🧭 Context

📚 Description

this adds a redirect to our new i18n dashboard.

it won't do anything until we release to main, so I won't move the i18n.npmx.dev subdomain until then

@danielroe danielroe requested a review from userquin March 26, 2026 22:31
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Mar 27, 2026 7:40pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Mar 27, 2026 7:40pm
npmx-lunaria Ignored Ignored Mar 27, 2026 7:40pm

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bfd43488-4cfc-4c51-b852-7d71ec74c24e

📥 Commits

Reviewing files that changed from the base of the PR and between 99da672 and 0c3f8f2.

📒 Files selected for processing (1)
  • vercel.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • vercel.json

📝 Walkthrough

Walkthrough

A new redirect rule was added to vercel.json that matches all request paths (/(.*)) when the request host is i18n.npmx.dev, redirecting them to https://main.npmx.dev/translation-status. No other redirect rules or configuration were changed.

Possibly related PRs

Suggested labels

chore

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description is directly related to the changeset, clearly stating it adds a redirect to the new i18n dashboard with relevant context about timing and subdomain management.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/i18n-redirect

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@danielroe danielroe enabled auto-merge March 26, 2026 22:47
@userquin
Copy link
Copy Markdown
Member

Not sure if we should use rewrites instead redirects, check https://vercel.com/kb/guide/can-i-redirect-from-a-subdomain-to-a-subpath

Vercel redirects/rewrites don't mention this case.

Co-authored-by: cylewaitforit <[email protected]>
@danielroe danielroe disabled auto-merge March 27, 2026 19:58
@danielroe danielroe merged commit c4776e5 into main Mar 27, 2026
23 checks passed
@danielroe danielroe deleted the chore/i18n-redirect branch March 27, 2026 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants