Skip to content

fix(i18n): add-missing-norwegian-nb-NO-translations#2715

Merged
graphieros merged 1 commit into
npmx-dev:mainfrom
bonsak:Fix/add-missing-norwegian-nb-NO-translations
May 11, 2026
Merged

fix(i18n): add-missing-norwegian-nb-NO-translations#2715
graphieros merged 1 commit into
npmx-dev:mainfrom
bonsak:Fix/add-missing-norwegian-nb-NO-translations

Conversation

@bonsak
Copy link
Copy Markdown
Contributor

@bonsak bonsak commented May 11, 2026

🔗 Linked issue

🧭 Context

Some keys in 'en.json' where missing in nb-NO.json

Updated missing nb-NO translations.

📚 Description

Missing keys in nb-NO.json was added and translated to Norwegian.

First translation pass generated by Opus 4.5. Second pass proofread by me.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment May 11, 2026 9:27am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview May 11, 2026 9:27am
npmx-lunaria Ignored Ignored May 11, 2026 9:27am

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 11, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f615648e-e9c8-4d82-b257-8124abb16d10

📥 Commits

Reviewing files that changed from the base of the PR and between f0ecbbf and a3df023.

📒 Files selected for processing (1)
  • i18n/locales/nb-NO.json

📝 Walkthrough

Summary by CodeRabbit

  • Localization
    • Added Norwegian language support for displaying license change details within the package versions interface.
    • Extended Norwegian translations for chart controls, including interface labels and tooltips.
    • Improved accessibility through enhanced descriptive text and copy functionality for better user experience and navigation support.

Walkthrough

This PR extends the Norwegian (nb-NO) i18n locale file with new translation strings. It adds license-change UI strings to the package versions section and expands the timeline section with chart control labels and improved accessibility copy text for visualization features.

Changes

i18n Translation Updates

Layer / File(s) Summary
License Change UI Strings
i18n/locales/nb-NO.json
Added license_change_help, license_change_warning, and license_change_record translation keys to support license-change information display in the package versions view.
Timeline Chart Accessibility & Copy
i18n/locales/nb-NO.json
Extended timeline translations with new chart subsection containing ARIA labels, control text (tab_aria_label, base_scale, zoom, reset_minimap), and enriched copy_alt accessibility strings for version events and overall chart description.

Possibly related PRs

  • npmx-dev/npmx.dev#2293: Modifies the same nb-NO locale file with overlapping package.versions and timeline translation keys.
  • npmx-dev/npmx.dev#2625: Adds timeline and chart-related i18n keys including copy_alt accessibility text to locale JSONs.
  • npmx-dev/npmx.dev#2677: Adds Norwegian (nb-NO) i18n entries to the same file with overlapping timeline and package translation work.

Suggested reviewers

  • ghostdevv
  • graphieros
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding missing Norwegian translations to the nb-NO locale file.
Description check ✅ Passed The description clearly explains the changeset: missing translation keys from en.json were identified and added to nb-NO.json with Norwegian translations.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
i18n/locales/nb-NO.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Contributor

@graphieros graphieros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🌿

@graphieros graphieros added this pull request to the merge queue May 11, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 11, 2026
@graphieros graphieros added this pull request to the merge queue May 11, 2026
Merged via the queue into npmx-dev:main with commit 274f781 May 11, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants