Skip to content

fix(OpenAI): React properly to server and 'high demand' errors (#730)#757

Open
leonardfischer wants to merge 1 commit intoopenai-php:mainfrom
leonardfischer:main
Open

fix(OpenAI): React properly to server and 'high demand' errors (#730)#757
leonardfischer wants to merge 1 commit intoopenai-php:mainfrom
leonardfischer:main

Conversation

@leonardfischer
Copy link
Copy Markdown

What:

  • Bug Fix
  • New Feature

Description:

This change will verify that a 5xx response will throw a ServerException including the affected response.

Related:

See issue #730

@iBotPeaches
Copy link
Copy Markdown
Collaborator

Looks good, I think we need some enhancements to our HttpTransporter tests though to be sure.

@leonardfischer
Copy link
Copy Markdown
Author

Hey @iBotPeaches thank you 👍Sounds good to me!
Just let me know if anything should be changed / updated... Or how I can implemeht those tests - I have not yet worked with pest 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants