fix: #2940 emit RealtimeHistoryUpdated when transcript_delta updates history#2977
Closed
nileshpatil6 wants to merge 2 commits intoopenai:mainfrom
Closed
fix: #2940 emit RealtimeHistoryUpdated when transcript_delta updates history#2977nileshpatil6 wants to merge 2 commits intoopenai:mainfrom
nileshpatil6 wants to merge 2 commits intoopenai:mainfrom
Conversation
transcript_delta mutates self._history via _get_new_history but never emits RealtimeHistoryUpdated, so UI consumers listening to history events miss live partial transcript changes. Emit the event consistently with the item_updated and item_deleted branches. Fixes openai#2940
seratch
changed the title
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
RealtimeSessionaccumulates transcript text and updatesself._historyon everytranscript_deltaevent, but never emitsRealtimeHistoryUpdated. UI consumers that follow the documented pattern of listening tohistory_added/history_updatedevents miss all live partial transcript changes.Every other branch that mutates history (
item_updated,item_deleted) correctly emitsRealtimeHistoryUpdated—transcript_deltais the only one that doesn't.Fix
Emit
RealtimeHistoryUpdatedimmediately after_get_new_historyin thetranscript_deltabranch, consistent with the other branches.Fixes #2940